Skip to content

Detect fs case sensitivity based on it's real behavior #11317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koroandr opened this issue Oct 3, 2016 · 0 comments · Fixed by #11332
Closed

Detect fs case sensitivity based on it's real behavior #11317

koroandr opened this issue Oct 3, 2016 · 0 comments · Fixed by #11332
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this

Comments

@koroandr
Copy link

koroandr commented Oct 3, 2016

TypeScript Version: 1.8.10

Code

In src/compiler/sys.ts there is such line (316):

const useCaseSensitiveFileNames = platform !== "win32" && platform !== "win64" && platform !== "darwin";

It detects case-sensitivity based on platform name, which is considered a bad practice.

I am working on Mac OS system with case-sensitive file system, so it's broken for me (I faced the problem with it while using tsify.

Expected behavior:
File system case sensitivity detection is based on it's real behavior.
Actual behavior:
File system case sensitivity detection is based on platform name.

@koroandr koroandr changed the title Detect fs case-sensitivity based on it's real behavior Detect fs case sensitivity based on it's real behavior Oct 3, 2016
@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this labels Oct 3, 2016
@mhegazy mhegazy added this to the TypeScript 2.1 milestone Oct 3, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Oct 3, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants