"Cannot read properties of undefined (reading 'name')" when using TS "Convert parameters to destructured object"

[DanTup]

I have a method like this:

	public logExtensionDeactivate(
		sessionDurationMs: number | undefined,
		totalDurationMs: number | undefined,
	) {
		// ...
	}

When I try to invoke the TS "Convert parameters to destructured object" nothing happens, and I get this in the developer console:

log.ts:460   ERR <semantic> TypeScript Server Error (5.9.3)
Cannot read properties of undefined (reading 'name')
TypeError: Cannot read properties of undefined (reading 'name')
    at getParameterName (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:149362:56)
    at c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:149249:27
    at map (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:2491:19)
    at createNewArgument (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:149248:22)
    at doChange5 (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:148934:9)
    at c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:148913:77
    at _ChangeTracker.with (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:179213:5)
    at Object.getRefactorEditsToConvertParametersToDestructuredObject [as getEditsForAction] (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:148913:60)
    at Object.getEditsForRefactor (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:146402:31)
    at Object.getEditsForRefactor2 [as getEditsForRefactor] (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:153925:32)
    at IpcIOSession.getEditsForRefactor (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:196411:49)
    at getEditsForRefactor (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:194555:43)
    at c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:196832:15
    at IpcIOSession.executeWithRequestId (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:196821:14)
    at IpcIOSession.executeCommand (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:196830:29)
    at IpcIOSession.onMessage (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:196878:68)
    at process.<anonymous> (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\_tsserver.js:519:14)
    at process.emit (node:events:519:28)
    at emit (node:internal/child_process:949:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:91:21): Error: <semantic> TypeScript Server Error (5.9.3)
Cannot read properties of undefined (reading 'name')
TypeError: Cannot read properties of undefined (reading 'name')
    at getParameterName (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:149362:56)
    at c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:149249:27
    at map (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:2491:19)
    at createNewArgument (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:149248:22)
    at doChange5 (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:148934:9)
    at c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:148913:77
    at _ChangeTracker.with (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:179213:5)
    at Object.getRefactorEditsToConvertParametersToDestructuredObject [as getEditsForAction] (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:148913:60)
    at Object.getEditsForRefactor (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:146402:31)
    at Object.getEditsForRefactor2 [as getEditsForRefactor] (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:153925:32)
    at IpcIOSession.getEditsForRefactor (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:196411:49)
    at getEditsForRefactor (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:194555:43)
    at c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:196832:15
    at IpcIOSession.executeWithRequestId (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:196821:14)
    at IpcIOSession.executeCommand (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:196830:29)
    at IpcIOSession.onMessage (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\typescript.js:196878:68)
    at process.<anonymous> (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\_tsserver.js:519:14)
    at process.emit (node:events:519:28)
    at emit (node:internal/child_process:949:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:91:21)
    at n.create (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\typescript-language-features\dist\extension.js:2:357397)
    at y.dispatchResponse (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\typescript-language-features\dist\extension.js:2:30831)
    at y.dispatchMessage (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\typescript-language-features\dist\extension.js:2:29272)
    at ChildProcess.<anonymous> (c:\Users\danny\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\typescript-language-features\dist\extension.js:2:28557)
    at ChildProcess.emit (node:events:519:28)
    at emit (node:internal/child_process:949:14)
    at processTicksAndRejections (node:internal/process/task_queues:91:21)

[DanTup]

Looks like it could be related to the (invalid) code that calls this function:

analytics.logExtensionDeactivate(reason, sessionDurationMs, totalDurationMs);

If I comment that line out, then the refactor completes.

I would have expected it to either work and ignore that line, or provide some feedback instead of silently failing.

[RyanCavanaugh]

We could really use a full repro

[DanTup]

Sorry, I should've made it simpler. Here's a copy/pastable repro.. Invoke the action on the first functions name.

// Invoke "Convert parameters to structured object" on this function name
	function logExtensionDeactivate(
		sessionDurationMs: number | undefined,
		totalDurationMs: number | undefined,
	) {
		// ...
	}

function x(reason: string, sessionDurationMs: number, totalDurationMs: number) {
	logExtensionDeactivate(reason, sessionDurationMs, totalDurationMs);
}