Add blade control #169
Add blade control #169
Conversation
|
Hi @NicoVermeir, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
This is linked to #168 @NicoVermeir You need to resolve some conflicts. |
|
Documentation link: microsoft/UWPCommunityToolkit-docs#15 |
| /// <summary> | ||
| /// Identifies the <see cref="Element"/> dependency property. | ||
| /// </summary> | ||
| public static readonly DependencyProperty ElementProperty = DependencyProperty.Register("Element", typeof(UIElement), typeof(Blade), new PropertyMetadata(default(UIElement))); |
There was a problem hiding this comment.
Please use nameof(Element)
|
@NicoVermeir, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| namespace Microsoft.Toolkit.Uwp.SampleApp.SamplePages | ||
| { | ||
| /// <summary> | ||
| /// An empty page that can be used on its own or navigated to within a Frame. |
There was a problem hiding this comment.
Can this be more descriptive (ie, not the template code)
unregistered tap event in blade updated comment in bladepage
|
LGTM |
1 similar comment
|
LGTM |
|
Hey, I do not get why Blade are clickable. I think they should not be |
|
@NicoVermeir I asked our design team to provide a guidance for the blade control sample. Are you ok to implement it if I give you the mockup? |
|
sure! |
|
really cool thanks! |
Added a blade control, similar to how the azure portal works. Also added sample in the app and updated docs