Adding ColumnResizer Control for Re-sizable columns/divider Issue #215
Conversation
|
Hi @IbraheemOsama, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@IbraheemOsama, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| /// </summary> | ||
| private void Resizer_PointerPressed(object sender, Windows.UI.Xaml.Input.PointerRoutedEventArgs e) | ||
| { | ||
| if (!_isResizing) |
There was a problem hiding this comment.
Shouldn't there be a CapturePointer call here?
There was a problem hiding this comment.
I totally removed the pointers events in the new Push
…r Rows, changing the grid to Thumb and changing events from pointer events to drag delta
| using System.Linq; | ||
| using System.Runtime.InteropServices.WindowsRuntime; | ||
| using Windows.Foundation; | ||
| using Windows.Foundation.Collections; |
There was a problem hiding this comment.
Clear redundant using statements.
|
Interesting Solution, I thought of using converters but I stuck in what should I do in the converter :) |
|
LGTM!!! Congrats, I know we are picky but the result is great! |
|
@deltakosh I finished the documentation and made a merged PR 2 days ago :) |
|
Omg...I need to sleep:) we just need another reviewer and we are good to go! Congrats |
|
Sorry to ask but we have conflicts here :( |
|
There is something wrong please don't merge now :) |
|
@deltakosh I resolved the conflicts, class OptionMenuItem was removed and I added it again. |
|
Actually this file was removed for true:) we don't need it anymore |
|
I removed it :) |
|
LGTM |
|
@deltakosh @dotMorten What is the next step ? :) |
|
Waiting for another review and we merge:) |
|
I merged it...Please create issues if you find a problem |
|
It could be cool if by default the splitter presents the grip icon (even if the user do not specify a content) |
|
And we should also think about using your great control for the property grid in the sample app :) |
|
@deltakosh Will work on the grip icon and the property grid :) |
|
A new PR would be perfect:) |
Adding Column Resizer Control which add resizing functionality to a Grid Column #201
I created the Control and a Sample page to demonstrate the functionality, I added this page to the Samples.json file to be visible in the application.
Waiting your feedback