Skip to content

Conversation

LanceMcCarthy
Copy link

Added FadeHeaderBehavior.cs to the Animations.Behaviors namespace. Added a FadeHeader demo to the Examples application.

@msftclas
Copy link

Hi @LanceMcCarthy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

{
public FadeHeaderBehaviorPage()
{
this.InitializeComponent();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove usages of "this."

@msftclas
Copy link

@LanceMcCarthy, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

}

// Implicit detection of a header if AssociatedObject is, or derived from, a ListView
if (HeaderElement == null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two if statements can be merged and see whether AssociatedObject is ListViewBase which both ListView and GridView are. It's ListViewBase which has the Header property on it.

@ScottIsAFool
Copy link
Contributor

LGTM

@deltakosh
Copy link
Contributor

Do you mind updating the documentation as well?
https://github.com/Microsoft/UWPCommunityToolkit-docs

@LanceMcCarthy
Copy link
Author

@deltakosh Almost done, have to add a new section because this behavior can't be added directly to the existing animations list

@deltakosh
Copy link
Contributor

Understood!

@LanceMcCarthy
Copy link
Author

Submitted PR for docs microsoft/UWPCommunityToolkit-docs#25

@deltakosh
Copy link
Contributor

LGTM

@deltakosh deltakosh merged commit 87048a5 into CommunityToolkit:dev Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants