-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Animation fadeheaderbehavior #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation fadeheaderbehavior #231
Conversation
…cottisafool) and squashed last bug on the behavior's demo page
Hi @LanceMcCarthy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
{ | ||
public FadeHeaderBehaviorPage() | ||
{ | ||
this.InitializeComponent(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove usages of "this."
@LanceMcCarthy, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
…d bind code examples
} | ||
|
||
// Implicit detection of a header if AssociatedObject is, or derived from, a ListView | ||
if (HeaderElement == null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two if statements can be merged and see whether AssociatedObject is ListViewBase which both ListView and GridView are. It's ListViewBase which has the Header property on it.
LGTM |
Do you mind updating the documentation as well? |
@deltakosh Almost done, have to add a new section because this behavior can't be added directly to the existing animations list |
Understood! |
Submitted PR for docs microsoft/UWPCommunityToolkit-docs#25 |
LGTM |
Added FadeHeaderBehavior.cs to the Animations.Behaviors namespace. Added a FadeHeader demo to the Examples application.