Service Provider for Microsoft Graph #273
Conversation
|
Hi @EricVernie, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| /// <summary> | ||
| /// Microsoft Graph Helper | ||
| /// </summary> | ||
| public class MicrosoftGraphHelper |
There was a problem hiding this comment.
This class should be marked internal to hide it
|
Seriously, this is utterly cool! Just some little tweaks and this will good to me |
|
@EricVernie, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| /// <summary> | ||
| /// Store the number of items | ||
| /// </summary> | ||
| private uint internalCount; |
There was a problem hiding this comment.
private fields should start with an underscore
| uint maxItems) | ||
| { | ||
| this.func = func; | ||
| this._func = func; |
| <Compile Include="Common\Constants.cs" /> | ||
| <Compile Include="Common\DelegateCommand{T}.cs" /> | ||
| <Compile Include="Common\SolidColorBrushConverter.cs" /> | ||
| <Compile Include="Common\Models\SolidColorBrushConverter.cs" /> |
There was a problem hiding this comment.
Why moving these files? (Note that I'm not opposed to this, just want to understand :))
|
All good to me, just need to see why moving files to /Common |
|
@EricVernie there are some conflict.. would you like to get latest changes and push an update out ? I will review when you are done |
|
@hermitdave done :) |
|
I merged it...Please create issues if you find a problem |
Related to Issue #263
To Test you need:
If you do not have any subscription, email me, I will send you a client id and test Account
Eric