Softer swipe snapping #390
Conversation
|
Hi @pekspro, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
| { | ||
| _leftCommandTransform = _leftCommandPanel.RenderTransform as CompositeTransform; | ||
|
|
||
| _leftCommandAnimation = new DoubleAnimation(); |
There was a problem hiding this comment.
Can you use our animation library ? like await _leftCommandAnimation.Offset...
There was a problem hiding this comment.
Interesting idea :-). From what I can see it is not possible to cancel an animation in the animation library. And that will be an issue for instance if user passes above the threshold, which starts the animation, and then immediately goes below the threshold again. Then the animation needs to be cancelled and text and icon show be set on a fixed position. This is covered in the current PR, not sure how to do that with the library.
I’m also working with another tiny PR with another animation that uses clipping which I hope gets accepted. And as I understand it this is not supported in the animation library. I think it’s a good idea all animation is created in the same way in this control.
That said, I’m willing to test this if you think this is a good idea :-).
There was a problem hiding this comment.
Animation can be cancelled like this:
var anim = foo.offset(0, 5);
anim.Start();
...
anim.Stop()
There was a problem hiding this comment.
Regarding clipping...as this is not yet supported by the toolkit itself, I'm fine doing it using sb
There was a problem hiding this comment.
Now the animations have been updated, and I like it :-). One notable thing is that the RenderTransform need to be reset every time Stop is called, since the AnimationSet changes this when the animation is created.
There was a problem hiding this comment.
Seriously, isn't that cool right now? :)
Love it!
|
can you please fix the conflicts? I'll merge then |
|
Now all conflicts have been fixed. |
| { | ||
| // This will cover extrem cases when previous state wasn't | ||
| // below threshold. | ||
| _leftCommandAnimationSet?.Stop(); |
There was a problem hiding this comment.
Need to wait for #418 to merge and retest before merging
There was a problem hiding this comment.
Just verified the change did not break this.
When you swipe a SlidableListItem passed the ActivationWidth threshold the icon and text “jumps” close to the margin. This PR introduces a tiny animation to make this jump a bit smoother.
And some types in the comments is also fixed.