Connection Helper

[hermitdave]

Expose ConnectionType property
Rework IsInternetAvailable property

Work on #455

[dnfclas]

Hi @hermitdave, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

[ghost]

Looks good so far, I think the ConnectionHelper class now helps in most of the cases 👍

[ghost]

This line can be removed.

[ghost]

I think the stylecop.json files don't belong to this PR. Please remove the lines from the project file.

[hermitdave]

@jlnostr done.. added those by mistake.. removed and pushed

[deltakosh]

Do you mind signing the new DNF CLA?

[dnfclas]

@hermitdave, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

[deltakosh]

There is always UWP alternative as we are only using UWP code ;)
But the point is all about simplicity. If it is as simple as this helper then we should not merge the PR.

But here I think the helper is clearly about centralizing things that could be on NetworkInformation or ConnectionProfile. This is not rocket science but more a convenient layer on top of the SDK (a lot of our helpers are like this)

[ScottIsAFool]

@ThreeFive-O I think the purpose of this is to offer explicit properties so that the dev just has one call to make, rather than several.

[ThreeFive-O]

Yeah, I realized when looking more closely at the code. This is why I deleted my comment, but then again, the word was already out :D Pardon me!

[deltakosh]

Please don't apologize. This is a community project. We all need to discuss. We cannot have a single opinion. This is great.