Expose HeaderTemplate in HeaderedTextBlock #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing #408 Replace TextBlock used for Header with ContentPresenter Expose HeaderTemplate instead of HeaderStyle
|
Hi @hermitdave, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
hermitdave
added
introduce breaking changes 💥
reviewers wanted
improvements ✨
and removed
cla-already-signed
labels
|
🚨 Breaking change alert 🚨 |
|
This is a difficult one as I can understand the breaking change (assuming you're talking about the HeaderStyle property). |
|
@jamesmcroft I'm not against the breaking change, just wanting to make sure it's highlighted and we don't forget about it :) |
|
I'm also ok with the breaking change |
deltakosh
approved these changes
Oct 18, 2016
20 tasks
ScottIsAFool
approved these changes
Oct 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #408
Replace TextBlock used for Header with ContentPresenter
Expose HeaderTemplate instead of HeaderStyle