Remove useless awaits of BaseObjectStorageHelper #493
Conversation
|
Hi @jlnostr, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
There is a build error |
| /// <typeparam name="T">Type of object saved</typeparam> | ||
| /// <param name="filePath">Path to the file that will contain the object</param> | ||
| /// <param name="value">Object to save</param> | ||
| /// <returns>Waiting task until completion</returns> |
There was a problem hiding this comment.
Maybe something clearer in the comment w.r.t return task?
There was a problem hiding this comment.
What do you think about Returns the <see cref="StorageFile"/> that the content is saved to.?
There was a problem hiding this comment.
Following the style here I think this might do
When this method completes, it returns the <see cref="StorageFile"/> where the Object was saved.
|
Looks good. |
Good suggestion @hermitdave 👍
|
LGTM |
To reduce the overhead, we should improve these two async tasks as well. @ScottIsAFool trained my eye to spot such things 👍