Skip to content

Conversation

hermitdave
Copy link
Contributor

Add attached property to enable binding Html content

@dnfclas
Copy link

dnfclas commented Oct 27, 2016

Hi @hermitdave, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

Copy link
Contributor

@ScottIsAFool ScottIsAFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in two minds as to whether the property (and associated methods) should be Html rather than HTML.

@hermitdave
Copy link
Contributor Author

hermitdave commented Oct 27, 2016

i was just thinking of expanding it out to not only have html content but also bind Uri.. let me mull this over and i will push updates soon

@hermitdave
Copy link
Contributor Author

@ScottIsAFool how about Content and ContentUri ?

@ScottIsAFool
Copy link
Contributor

Sounds good.

@deltakosh
Copy link
Contributor

For #528

@deltakosh
Copy link
Contributor

LGTM

@deltakosh deltakosh merged commit 6d2db14 into dev Oct 27, 2016
@ScottIsAFool ScottIsAFool deleted the WebViewExtensions branch October 27, 2016 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants