enabled paging support for fb service requests

[cbarkerms]

#366

The service calls to Facebook are now paged - defaulting to a page size 20 and a maximum of 5 pages, which can be easily overridden.

Key changes -

▪ Update to winsdkfb nuget with paging fix

▪ (Potential) breaking changes

FacebookService.Instance.GetUserAlbumsAsync(); now returns 

    Task<IncrementalLoadingCollection<FacebookAlbumSource, FacebookAlbum>>

    Not

    Task<List<FacebookAlbum>>

FacebookService.Instance.GetUserPhotosByAlbumIdAsync(); now returns 

    Task<IncrementalLoadingCollection<FacebookPhotoSource, FacebookPhoto>> 

    Not

    Task<List<FacebookPhoto>> 

FacebookService.Instance.RequestAsync(); now returns

    Task<IncrementalLoadingCollection<FacebookRequestSource<T>, T>>

    Not

    Task<List<T>>

These generally will not require changes if you are assigning directly to an ItemsSource, or letting the compiler figure the type out with a 'var'. The SampleApp for example did not require any changes.

[dnfclas]

Hi @cbarkerms, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

[deltakosh]

regarding breaking changes: Is there a way to keep the previous signatures and add new methods which return the incremental collections

[cbarkerms]

I considered that, but it was going to result in bloat and the breaking changes are minor (and in many cases non-existent) IMO.

[deltakosh]

I would love to get more thoughts here. You're still returning an IList. So this could be enough.

[deltakosh]

I think that async/await is not required

[hermitdave]

agreed not need to await.. just return the task and let the caller await

[deltakosh]

we need to update the nuspec as well

[cbarkerms]

done

[deltakosh]

why adding Fields here?

[hermitdave]

we have a method with original signature.. we should continue using that.. no need to change that here

[cbarkerms]

Either GetUserAlbumsAsync() or GetUserAlbumsAsync(20) result in an ambiguous call:

The call is ambiguous between the following methods or properties: 'FacebookService.GetUserAlbumsAsync(int, string)' and 'FacebookService.GetUserAlbumsAsync(int, string, int)'

Here are the two overloads:

1. public async Task<List> GetUserAlbumsAsync(int maxRecords = 20, string fields = null)
2. public async Task<IncrementalLoadingCollection<FacebookRequestSource, FacebookAlbum>> GetUserAlbumsAsync(int pageSize = 20, string fields = null, int maxPages = 5)

#1 is the original, unchanged signature. I could remove optionals off of #2 to resolve? New signature would be:

public async Task<IncrementalLoadingCollection<FacebookRequestSource, FacebookAlbum>> GetUserAlbumsAsync(int pageSize, int maxPages, string fields = null)

[deltakosh]

I think this makes sense as you will call the second one for paging support

[hermitdave]

methods with original signatures have been added.. should we not leave them as is ? or are we marking those obsolete and suggesting use of new ones ?

[cbarkerms]

please see above - we can potentially avoid deprecating...

[deltakosh]

Some headers are missing (the CI failed) and you need to sign the CLA from DNF :)

[dnfclas]

@cbarkerms, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;