Skip to content

Peeking References for a extended class #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manuartero opened this issue Feb 21, 2019 · 1 comment
Closed

Peeking References for a extended class #4481

manuartero opened this issue Feb 21, 2019 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@manuartero
Copy link

Environment data

  • VS Code version: 1.31.1 (1.31.1)
  • Extension version (available under the Extensions sidebar): 1b8e8302e405050205e69b59abb3559592bb9e60
  • OS and version: macOS Mojave 10.14.3
  • Python version (& distribution if applicable, e.g. Anaconda): 3.7.1 64-bit
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
  • Relevant/affected Python packages and their versions:
    • Python 2019.1.0 (microsoft)
    • python-snippets 0.2.0 (cstrap)

Expected behaviour

Peeking References for a Python class might show any class extending it.

Class A():

...

Class B(A): # A is referenced here

Actual behaviour

Picking references of a Python class does not list any ussage of that class as parent class.

Steps to reproduce:

Prerequisites

In the code base, we have at least two classes, A & B. B extends A.


  1. Cursor over Python class A
  2. Peek references (via command palette or shortcut or right clicking)
  3. A ussage from B class is not shown

Logs

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

None.

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

2console.ts:134 [Extension Host] Python Extension: Cached data exists getEnvironmentVariables, /Users/martero/workspace/tuenti/flow/flow_core/flow_core/tasks/basetask.py

Relevant user config

  "python.linting.lintOnSave": true,
  "python.linting.pep8CategorySeverity.E": "Warning",
  "python.linting.pylintEnabled": true,
  "python.venvPath": "~/.virtualenvs",
  // "python.jediEnabled": false, // TRIED BOTH, TRUE & FALSE
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Feb 21, 2019
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug feature-interpreter labels Feb 21, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Feb 21, 2019
@luabud
Copy link
Member

luabud commented Sep 11, 2019

Fixed upstream.

@luabud luabud closed this as completed Sep 11, 2019
@ghost ghost removed the needs upstream fix label Sep 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants