You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have recently been migrating from the older System.Data.SqlClient provider to the new Microsoft.Data.SqlClient. While these are mostly compatible, there are some keywords only recognized by the new provider. This becomes an issue if one is using the new driver's ConnectionStringBuilder and then passes the resulting CS to code that still uses the old provider. There is a workaround posted a bit later in the thread linked above but it involves modifying the CS after it's been generated which is not great.
I think ideally MiniProfiler should be able to make use of the new provider (possibly in addition to the old one?). Are there any plans to add support for this at a future date (or am I otherwise missing something)?
One solution would be to allow passing a Func<DbConnection> instead of explicitly new-ing the SqlConnection in the SqlServerStorage class but this may be problematic since its base class keeps a reference to the connection string itself. Another solution would be to release separate packages using the old and new providers - but this seems like a much bigger effort.
The text was updated successfully, but these errors were encountered:
We have recently been migrating from the older
System.Data.SqlClient
provider to the newMicrosoft.Data.SqlClient
. While these are mostly compatible, there are some keywords only recognized by the new provider. This becomes an issue if one is using the new driver'sConnectionStringBuilder
and then passes the resulting CS to code that still uses the old provider. There is a workaround posted a bit later in the thread linked above but it involves modifying the CS after it's been generated which is not great.I think ideally MiniProfiler should be able to make use of the new provider (possibly in addition to the old one?). Are there any plans to add support for this at a future date (or am I otherwise missing something)?
One solution would be to allow passing a
Func<DbConnection>
instead of explicitlynew
-ing the SqlConnection in theSqlServerStorage
class but this may be problematic since its base class keeps a reference to the connection string itself. Another solution would be to release separate packages using the old and new providers - but this seems like a much bigger effort.The text was updated successfully, but these errors were encountered: