Skip to content

Expose rate limiting response headers #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chalenge opened this issue Jan 29, 2024 · 0 comments · Fixed by #309
Closed

Expose rate limiting response headers #299

chalenge opened this issue Jan 29, 2024 · 0 comments · Fixed by #309

Comments

@chalenge
Copy link
Contributor

chalenge commented Jan 29, 2024

This is related to #277.

The new error handling suppresses response headers useful for handling retry logic for rate-limiting and transient server errors.

From the Jira docs the Jira API exposes some headers Retry-After, X-RateLimit-Reset and X-RateLimit-NearLimit headers which can be used for error retry handling logic and since these are axios errors will always suppress those headers and doesn't seem to be a way to override what errors it returns in the client

I know the original intention was to avoid having axios errors exposing headers and other information that could cause leaks. Can we maybe expose these as an exception or maybe provide a way to config specific headers the user wants to be returned in the errors. Not sure what other headers may be useful for other error handling logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants