[TASK] Remove getLineNo()

Also no longer allow zero to be passed as line number to `setPosition()`.

Closes #974.

Author: JakeQZ

CHANGELOG.md

@@ -80,6 +80,9 @@ Please also have a look at our
 
 ### Removed
 
+- Remove `getLineNo()` from these classes (use `getLineNumber()` instead):
+  `Comment`, `CSSList`, `SourceException`, `Charset`, `CSSNamespace`, `Import`,
+  `Rule`, `DeclarationBlock`, `RuleSet`, `CSSFunction`, `Value` (#1258)
 - Remove `Rule::getColNo()` (use `getColumnNumber()` instead) (#1287)
 - Passing a string as the first argument to `getAllValues()` is no longer
   supported and will not work;

src/CSSList/AtRuleBlockList.php

@@ -24,9 +24,9 @@ class AtRuleBlockList extends CSSBlockList implements AtRule
 
     /**
      * @param non-empty-string $type
-     * @param int<0, max> $lineNumber
+     * @param int<1, max>|null $lineNumber
      */
-    public function __construct(string $type, string $arguments = '', int $lineNumber = 0)
+    public function __construct(string $type, string $arguments = '', ?int $lineNumber = null)
     {
         parent::__construct($lineNumber);
         $this->type = $type;

src/CSSList/CSSList.php

@@ -48,9 +48,9 @@ abstract class CSSList implements CSSElement, CSSListItem, Positionable
     protected $contents = [];
 
     /**
-     * @param int<0, max> $lineNumber
+     * @param int<1, max>|null $lineNumber
      */
-    public function __construct(int $lineNumber = 0)
+    public function __construct(?int $lineNumber = null)
     {
         $this->setPosition($lineNumber);
     }

src/Comment/Comment.php

@@ -21,9 +21,9 @@ class Comment implements Positionable, Renderable
     protected $commentText;
 
     /**
-     * @param int<0, max> $lineNumber
+     * @param int<1, max>|null $lineNumber
      */
-    public function __construct(string $commentText = '', int $lineNumber = 0)
+    public function __construct(string $commentText = '', ?int $lineNumber = null)
     {
         $this->commentText = $commentText;
         $this->setPosition($lineNumber);

src/Parsing/SourceException.php

@@ -12,9 +12,9 @@ class SourceException extends \Exception implements Positionable
     use Position;
 
     /**
-     * @param int<0, max> $lineNumber
+     * @param int<1, max>|null $lineNumber
      */
-    public function __construct(string $message, int $lineNumber = 0)
+    public function __construct(string $message, ?int $lineNumber = null)
     {
         $this->setPosition($lineNumber);
         if ($lineNumber !== 0) {

src/Parsing/UnexpectedTokenException.php

@@ -11,9 +11,9 @@ class UnexpectedTokenException extends SourceException
 {
     /**
      * @param 'literal'|'identifier'|'count'|'expression'|'search'|'custom' $matchType
-     * @param int<0, max> $lineNumber
+     * @param int<1, max>|null $lineNumber
      */
-    public function __construct(string $expected, string $found, string $matchType = 'literal', int $lineNumber = 0)
+    public function __construct(string $expected, string $found, string $matchType = 'literal', ?int $lineNumber = null)
     {
         $message = "Token “{$expected}” ({$matchType}) not found. Got “{$found}”.";
         if ($matchType === 'search') {

src/Position/Position.php

@@ -31,14 +31,6 @@ public function getLineNumber(): ?int
         return $this->lineNumber;
     }
 
-    /**
-     * @return int<0, max>
-     */
-    public function getLineNo(): int
-    {
-        return $this->getLineNumber() ?? 0;
-    }
-
     /**
      * @return int<0, max>|null
      */
@@ -55,8 +47,7 @@ public function getColumnNumber(): ?int
      */
     public function setPosition(?int $lineNumber, ?int $columnNumber = null): Positionable
     {
-        // The conditional is for backwards compatibility (backcompat); `0` will not be allowed in future.
-        $this->lineNumber = $lineNumber !== 0 ? $lineNumber : null;
+        $this->lineNumber = $lineNumber;
         $this->columnNumber = $columnNumber;
 
         return $this;

src/Position/Positionable.php

@@ -16,22 +16,13 @@ interface Positionable
      */
     public function getLineNumber(): ?int;
 
-    /**
-     * @return int<0, max>
-     *
-     * @deprecated in version 8.9.0, will be removed in v9.0. Use `getLineNumber()` instead.
-     */
-    public function getLineNo(): int;
-
     /**
      * @return int<0, max>|null
      */
     public function getColumnNumber(): ?int;
 
     /**
-     * @param int<0, max>|null $lineNumber
-     *        Providing zero for this parameter is deprecated in version 8.9.0, and will not be supported from v9.0.
-     *        Use `null` instead when no line number is available.
+     * @param int<1, max>|null $lineNumber
      * @param int<0, max>|null $columnNumber
      *
      * @return $this fluent interface

src/Property/CSSNamespace.php

@@ -31,9 +31,9 @@ class CSSNamespace implements AtRule, Positionable
 
     /**
      * @param CSSString|URL $url
-     * @param int<0, max> $lineNumber
+     * @param int<1, max>|null $lineNumber
      */
-    public function __construct($url, ?string $prefix = null, int $lineNumber = 0)
+    public function __construct($url, ?string $prefix = null, ?int $lineNumber = null)
     {
         $this->url = $url;
         $this->prefix = $prefix;

src/Property/Charset.php

@@ -29,9 +29,9 @@ class Charset implements AtRule, Positionable
     private $charset;
 
     /**
-     * @param int<0, max> $lineNumber
+     * @param int<1, max>|null $lineNumber
      */
-    public function __construct(CSSString $charset, int $lineNumber = 0)
+    public function __construct(CSSString $charset, ?int $lineNumber = null)
     {
         $this->charset = $charset;
         $this->setPosition($lineNumber);