[TASK] Remove getLineNo() and getColNo()

Part of #974.

Author: JakeQZ

CHANGELOG.md

@@ -78,6 +78,10 @@ Please also have a look at our
 
 ### Removed
 
+- `getLineNo()` is removed from these classes (use `getLineNumber()` instead):
+  `Comment`, `CSSList`, `SourceException`, `Charset`, `CSSNamespace`, `Import`,
+  `Rule`, `DeclarationBlock`, `RuleSet`, `CSSFunction`, `Value` (#1258)
+- `Rule::getColNo()` is removed (use `getColumnNumber()` instead) (#1258)
 - Passing a string as the first argument to `getAllValues()` is no longer
   supported and will not work;
   the search pattern should now be passed as the second argument (#1243)

src/RuleSet/RuleSet.php

@@ -107,7 +107,7 @@ public function addRule(Rule $ruleToAdd, ?Rule $sibling = null): void
             $siblingPosition = \array_search($sibling, $this->rules[$propertyName], true);
             if ($siblingPosition !== false) {
                 $position = $siblingPosition;
-                $ruleToAdd->setPosition($sibling->getLineNo(), $sibling->getColNo() - 1);
+                $ruleToAdd->setPosition($sibling->getLineNumber(), $sibling->getColNo() - 1);
             }
         }
         if ($ruleToAdd->getLineNo() === 0 && $ruleToAdd->getColNo() === 0) {

tests/Unit/CSSList/AtRuleBlockListTest.php

@@ -117,7 +117,7 @@ public function atRuleArgsReturnsArgumentsProvidedToConstructor(): void
     /**
      * @test
      */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
+    public function getLineNumberReturnsLineNumberProvidedToConstructor(): void
     {
         $lineNumber = 42;
 

tests/Unit/CSSList/CSSListTest.php

@@ -60,7 +60,7 @@ public function implementsCSSListItem(): void
     /**
      * @test
      */
-    public function getLineNoByDefaultReturnsZero(): void
+    public function getLineNumberByDefaultReturnsZero(): void
     {
         $subject = new ConcreteCSSList();
 
@@ -70,7 +70,7 @@ public function getLineNoByDefaultReturnsZero(): void
     /**
      * @test
      */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
+    public function getLineNumberReturnsLineNumberProvidedToConstructor(): void
     {
         $lineNumber = 42;
 

tests/Unit/CSSList/KeyFrameTest.php

@@ -71,7 +71,7 @@ public function isCSSList(): void
     /**
      * @test
      */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
+    public function getLineNumberReturnsLineNumberProvidedToConstructor(): void
     {
         $lineNumber = 42;
 

tests/Unit/Comment/CommentTest.php

@@ -60,7 +60,7 @@ public function setCommentSetsComments(): void
     /**
      * @test
      */
-    public function getLineNoOnEmptyInstanceReturnsZero(): void
+    public function getLineNumberOnEmptyInstanceReturnsZero(): void
     {
         $subject = new Comment();
 
@@ -70,7 +70,7 @@ public function getLineNoOnEmptyInstanceReturnsZero(): void
     /**
      * @test
      */
-    public function getLineNoInitiallyReturnsLineNumberPassedToConstructor(): void
+    public function getLineNumberInitiallyReturnsLineNumberPassedToConstructor(): void
     {
         $lineNumber = 42;
         $subject = new Comment('', $lineNumber);

tests/Unit/Parsing/OutputExceptionTest.php

@@ -35,7 +35,7 @@ public function getMessageReturnsMessageProvidedToConstructor(): void
     /**
      * @test
      */
-    public function getLineNoByDefaultReturnsZero(): void
+    public function getLineNumberByDefaultReturnsZero(): void
     {
         $exception = new OutputException('foo');
 
@@ -45,7 +45,7 @@ public function getLineNoByDefaultReturnsZero(): void
     /**
      * @test
      */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
+    public function getLineNumberReturnsLineNumberProvidedToConstructor(): void
     {
         $lineNumber = 17;
         $exception = new OutputException('foo', $lineNumber);

tests/Unit/Parsing/SourceExceptionTest.php

@@ -26,7 +26,7 @@ public function getMessageReturnsMessageProvidedToConstructor(): void
     /**
      * @test
      */
-    public function getLineNoByDefaultReturnsZero(): void
+    public function getLineNumberByDefaultReturnsZero(): void
     {
         $exception = new SourceException('foo');
 
@@ -36,7 +36,7 @@ public function getLineNoByDefaultReturnsZero(): void
     /**
      * @test
      */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
+    public function getLineNumberReturnsLineNumberProvidedToConstructor(): void
     {
         $lineNumber = 17;
         $exception = new SourceException('foo', $lineNumber);

tests/Unit/Parsing/UnexpectedEOFExceptionTest.php

@@ -24,7 +24,7 @@ public function extendsUnexpectedTokenException(): void
     /**
      * @test
      */
-    public function getLineNoByDefaultReturnsZero(): void
+    public function getLineNumberByDefaultReturnsZero(): void
     {
         $exception = new UnexpectedEOFException('expected', 'found');
 
@@ -34,7 +34,7 @@ public function getLineNoByDefaultReturnsZero(): void
     /**
      * @test
      */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
+    public function getLineNumberReturnsLineNumberProvidedToConstructor(): void
     {
         $lineNumber = 17;
         $exception = new UnexpectedEOFException('expected', 'found', 'literal', $lineNumber);

tests/Unit/Parsing/UnexpectedTokenExceptionTest.php

@@ -24,7 +24,7 @@ public function extendsSourceException(): void
     /**
      * @test
      */
-    public function getLineNoByDefaultReturnsZero(): void
+    public function getLineNumberByDefaultReturnsZero(): void
     {
         $exception = new UnexpectedTokenException('expected', 'found');
 
@@ -34,7 +34,7 @@ public function getLineNoByDefaultReturnsZero(): void
     /**
      * @test
      */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
+    public function getLineNumberReturnsLineNumberProvidedToConstructor(): void
     {
         $lineNumber = 17;
         $exception = new UnexpectedTokenException('expected', 'found', 'literal', $lineNumber);