Skip to content
This repository was archived by the owner on Aug 12, 2020. It is now read-only.

Contribute to react-scripts-ts instead of maintaining own fork #65

Open
sverhoeven opened this issue Sep 15, 2017 · 0 comments
Open

Contribute to react-scripts-ts instead of maintaining own fork #65

sverhoeven opened this issue Sep 15, 2017 · 0 comments
Assignees
Labels

Comments

@sverhoeven
Copy link
Member

The Typescript quickstart uses react-scripts-ts and as such seems to be the go to for starting a React+TS based project.

I converted https://github.com/3D-e-Chem/molviewer-tsx/tree/react-scripts-ts from using this repo (ours) to the react-scripts-ts (theirs). The molviewer uses prettier for formatting. To make linter pass the semi-colon, interface-name, typedef, no-any rules where removed.

This repo is different (ours -> theirs) by:

  • awesome-typescript-loader (+ babel) -> ts-loader
  • tsconfig different no-'s checks
  • own tslint package -> tslint extends tslint-react with lots of overwrites, see Externalise ts-lint rules wmonk/create-react-app-typescript#112
  • ts declaration for fetch() needed because target is es5 -> not needed
  • typescript specific README -> same as facebook
  • lint command -> not included, mimic with tslint --type-check -t verbose --project .
  • @types/* + react-scripts in devDeps -> in deps
  • coverage must be run without cache and single worker -> coverage errors on src/*.d.ts
  • missing registerServiceWorker -> includes registerServiceWorker

Most of the improvements in our repo can be added to theirs.
After which we could moth-ball this repo, freeing us from it's maintenance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants