Skip to content

Workaround for reindexing bug in Pandas 1.0.0 #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Workaround for reindexing bug in Pandas 1.0.0 #142

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b69a9d
tentative workaround for pandas 1.0.0 reindexing bug
kandersolar Feb 5, 2020
a130352
Bump requirements to Pandas <= 1.0.0 for Travis upgrade-strategy=eage…
cdeline Mar 6, 2020
551b5ca
update pandas req to exclude 1.0.0, 1.0.1
kandersolar Mar 16, 2020
95e6b1a
Revert "tentative workaround for pandas 1.0.0 reindexing bug"
kandersolar Mar 16, 2020
ae388df
setup.py version lists are combined with AND, so <1.0.0, >=1.0.2 wasn…
kandersolar Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rdtools/clearsky_temperature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,13 @@ def get_clearsky_tamb(times, latitude, longitude, window_size=40,
df = df.resample(freq_actual).interpolate(method='linear')
df['month'] = df.index.month

# workaround for pandas #26683 reindexing bug in pandas 1.0.0
tz = times.tz
df.index = df.index.tz_convert('UTC').tz_localize(None)
times = times.tz_convert('UTC').tz_localize(None)
df = df.reindex(times, method='nearest')
times = times.tz_localize('UTC').tz_convert(tz)
df.index = df.index.tz_localize('UTC').tz_convert(tz)

utc_offsets = [y.utcoffset().total_seconds() / 3600.0 for y in df.index]

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

INSTALL_REQUIRES = [
'numpy >= 1.12',
'pandas >= 0.23.0, <1.0.0',
'pandas >= 0.23.0, <=1.0.0',
Copy link
Member Author

@kandersolar kandersolar Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'pandas >= 0.23.0, <=1.0.0',
'pandas >= 0.23.0, <1.0.0, >=1.0.2', # exclude 1.0.0 & 1.0.1 for GH142

Pandas 1.0.2 was released yesterday with the fix for this issue. Should we forget the workaround and just exclude 1.0.0 and 1.0.1 like this? I'd guess that people will move on from 1.0.0 and 1.0.1 pretty quickly, so IMHO it's not worth maintaining weird code to support those versions.

Copy link
Collaborator

@mdeceglie mdeceglie Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree and support requiring 1.0.2

'statsmodels >= 0.8.0',
'scipy >= 0.19.1',
'h5py >= 2.7.1',
Expand Down