Skip to content

Remove low power cutoff in filtering.clipping_filter #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 20, 2020
Merged

Remove low power cutoff in filtering.clipping_filter #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
01c966c
remove low power cutoff in filtering.clipping_filter
kandersolar Feb 6, 2020
f1d736b
Update v2.0.0.rst
kandersolar Feb 6, 2020
0562bce
shame on me for not running tests locally
kandersolar Feb 6, 2020
7cfee2a
Update degradation_and_soiling_example.ipynb
kandersolar Apr 16, 2020
667f174
Merge branch 'development' into fix_84_clipfilter
kandersolar Apr 16, 2020
b9f2c8b
Update degradation_and_soiling_example.ipynb
kandersolar Apr 16, 2020
43e1483
change normalized filter to > 0.01 per internal discussion
kandersolar Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 77 additions & 74 deletions docs/degradation_and_soiling_example.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/sphinx/source/changelog/v2.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ v2.0.0 (MONTH DAY, YEAR)

API Changes
-----------
* Remove `low_power_cutoff` parameter in `filtering.clipping_filter` (:issue:`84`).

Enhancements
------------
Expand Down
10 changes: 4 additions & 6 deletions rdtools/filtering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,29 +45,27 @@ def tcell_filter(tcell, low_tcell_cutoff=-50, high_tcell_cutoff=110):
return (tcell > low_tcell_cutoff) & (tcell < high_tcell_cutoff)


def clip_filter(power, quant=0.98, low_power_cutoff=0.01):
def clip_filter(power, quant=0.98):
'''
Filter data points likely to be affected by clipping
with power greater than or equal to 99% of the `quant`
quantile and less than `low_power_cutoff`
quantile.

Parameters
----------
power : pd.Series
AC power in Watts
quant : float, default 0.98
Value for upper threshold quantile
low_power_cutoff : float, default 0.01
Value for low-power cutoff (in Watts)

Returns
-------
pd.Series
Boolean Series of whether the given measurement is below 99% of the
quantile filter and above the low-power cutoff.
quantile filter.
'''
v = power.quantile(quant)
return (power < v * 0.99) & (power > low_power_cutoff)
return (power < v * 0.99)


def csi_filter(measured_poa, clearsky_poa, threshold=0.15):
Expand Down
11 changes: 1 addition & 10 deletions rdtools/test/filtering_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,21 +66,12 @@ def setUp(self):
# use of the Series.quantile() method.

def test_clip_filter_upper(self):
filtered = clip_filter(self.power, quant=0.98,
low_power_cutoff=0)
filtered = clip_filter(self.power, quant=0.98)

# Expect 99% of the 98th quantile to be filtered
expected_result = self.power < (98 * 0.99)
self.assertTrue((expected_result == filtered).all())

def test_clip_filter_low_cutoff(self):
filtered = clip_filter(self.power, quant=0.98,
low_power_cutoff=2)

# Expect power <=2 to be filtered
expected_result = (self.power > 2)
self.assertTrue((expected_result.iloc[0:5] == filtered.iloc[0:5]).all())


if __name__ == '__main__':
unittest.main()