Skip to content

changelog for energy_from_power, normalize_with_x #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2020
Merged

changelog for energy_from_power, normalize_with_x #172

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
881009b
changelog for energy_from_power, normalize_with_x
kandersolar Apr 24, 2020
1cf9942
Merge branch 'development' into energy_from_power_changelog
kandersolar Apr 28, 2020
bb3ccdd
revise changelog
kandersolar Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/sphinx/source/changelog/v2.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,18 @@ v2.0.0 (MONTH DAY, YEAR)

API Changes
-----------
* The behavior of :py:func:`~rdtools.normalization.normalize_with_pvwatts`
and :py:func:`~rdtools.normalization.normalize_with_sapm` have changed to
expect input energy in the moving average form calculated by
:py:func:`~rdtools.normalization.energy_from_power` (:pull:`105`, :pull:`108`).
Copy link
Collaborator

@mdeceglie mdeceglie Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would characterize it as a trapezoidal rule integration rather than a moving average, but that may be moot because I suggest revising to:

The calculations internal to normalize_with_pvwatts and normalize with sapm have changed. Generally, when working with raw power data it should be converted to right-labeled energy with energy_from_power before being used with the normalization functions.

The PR links will allow folks to dig into the details if they need to.

Copy link
Member Author

@kandersolar kandersolar Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The moving average bit was quoting this: https://github.com/NREL/rdtools/blob/development/rdtools/normalization.py#L502

But agreed that your version is better anyway.

* Remove ``low_power_cutoff`` parameter in :py:func:`~rdtools.filtering.clip_filter` (:issue:`84`).

Enhancements
------------
* Add new :py:mod:`~rdtools.soiling` module to implement the stochastic rate and
recovery method (:pull:`112`).
* Add new functions :py:func:`~rdtools.normalization.energy_from_power` and
:py:func:`~rdtools.normalization.interpolate`.
:py:func:`~rdtools.normalization.interpolate` (:pull:`105`, :pull:`108`).
* Add new :py:mod:`~rdtools.plotting` module for generating standard plots.
* Add parameter ``convergence_threshold`` to
:py:func:`~rdtools.normalization.irradiance_rescale` (:pull:`152`).
Expand Down