addressing final formatting comments

Author: ksimpson-work

cuda_core/tests/conftest.py

@@ -1,13 +1,13 @@
-# Copyright 2021-2024 NVIDIA Corporation.  All rights reserved.
+# Copyright 2024 NVIDIA Corporation.  All rights reserved.
 #
 # Please refer to the NVIDIA end user license agreement (EULA) associated
 # with this source code for terms and conditions that govern your use of
 # this software. Any use, reproduction, disclosure, or distribution of
 # this software and related documentation outside the terms of the EULA
 # is strictly prohibited.
 
-import pytest
 from cuda.core.experimental._device import Device
+import pytest
 
 @pytest.fixture(scope="module")
 def init_cuda():

cuda_core/tests/example_tests/test_basic_examples.py

@@ -1,4 +1,4 @@
-# Copyright 2021-2024 NVIDIA Corporation.  All rights reserved.
+# Copyright 2024 NVIDIA Corporation.  All rights reserved.
 #
 # Please refer to the NVIDIA end user license agreement (EULA) associated
 # with this source code for terms and conditions that govern your use of

cuda_core/tests/example_tests/utils.py

@@ -1,4 +1,4 @@
-# Copyright 2021-2024 NVIDIA Corporation.  All rights reserved.
+# Copyright 2024 NVIDIA Corporation.  All rights reserved.
 #
 # Please refer to the NVIDIA end user license agreement (EULA) associated
 # with this source code for terms and conditions that govern your use of
@@ -51,4 +51,4 @@ def run_example(samples_path, filename, env=None):
         sys.argv = old_argv
         # further reduce the memory watermark
         gc.collect()
-        cp.get_default_memory_pool().free_all_blocks()
+        cp.get_default_memory_pool().free_all_blocks()

cuda_core/tests/test_device.py

@@ -1,4 +1,4 @@
-# Copyright 2021-2024 NVIDIA Corporation.  All rights reserved.
+# Copyright 2024 NVIDIA Corporation.  All rights reserved.
 #
 # Please refer to the NVIDIA end user license agreement (EULA) associated
 # with this source code for terms and conditions that govern your use of
@@ -12,18 +12,17 @@
                              precondition
 import pytest
 
-
 def test_device_repr():
     device = Device(0)
     assert str(device).startswith('<Device 0')
 
-# def test_device_alloc(init_cuda):
-#     device = Device()
-#     buffer = device.allocate(1024)
-#     device.sync()
-#     assert buffer.handle != 0
-#     assert buffer.size == 1024
-#     assert buffer.device_id == 0
+def test_device_alloc(init_cuda):
+    device = Device()
+    buffer = device.allocate(1024)
+    device.sync()
+    assert buffer.handle != 0
+    assert buffer.size == 1024
+    assert buffer.device_id == 0
 
 def test_device_set_current():
     device = Device()
@@ -65,4 +64,4 @@ def test_compute_capability():
         cudart.cudaDeviceAttr.cudaDevAttrComputeCapabilityMinor, device.device_id))
     expected_cc = ComputeCapability(major, minor)
     assert device.compute_capability == expected_cc
-    
+ 

cuda_core/tests/test_event.py

@@ -1,4 +1,4 @@
-# Copyright 2021-2024 NVIDIA Corporation.  All rights reserved.
+# Copyright 2024 NVIDIA Corporation.  All rights reserved.
 #
 # Please refer to the NVIDIA end user license agreement (EULA) associated
 # with this source code for terms and conditions that govern your use of
@@ -12,7 +12,6 @@
 from cuda.core.experimental._device import Device
 import pytest
 
-
 def test_is_timing_disabled():
     options = EventOptions(enable_timing=False)
     event = Event._init(options)

cuda_core/tests/test_launcher.py

@@ -1,16 +1,16 @@
-# Copyright 2021-2024 NVIDIA Corporation.  All rights reserved.
+# Copyright 2024 NVIDIA Corporation.  All rights reserved.
 #
 # Please refer to the NVIDIA end user license agreement (EULA) associated
 # with this source code for terms and conditions that govern your use of
 # this software. Any use, reproduction, disclosure, or distribution of
 # this software and related documentation outside the terms of the EULA
 # is strictly prohibited.
 
+from cuda import cuda
 from cuda.core.experimental._launcher import LaunchConfig
 from cuda.core.experimental._stream import Stream
 from cuda.core.experimental._device import Device
 from cuda.core.experimental._utils import handle_return
-from cuda import cuda
 import pytest
 
 def test_launch_config_init():
@@ -64,4 +64,3 @@ def test_launch_config_shmem_size():
 
     config = LaunchConfig(grid=(1, 1, 1), block=(1, 1, 1), stream=None)
     assert config.shmem_size == 0
-    

cuda_core/tests/test_memory.py

@@ -1,29 +1,28 @@
-# Copyright 2021-2024 NVIDIA Corporation.  All rights reserved.
+# Copyright 2024 NVIDIA Corporation.  All rights reserved.
 #
 # Please refer to the NVIDIA end user license agreement (EULA) associated
 # with this source code for terms and conditions that govern your use of
 # this software. Any use, reproduction, disclosure, or distribution of
 # this software and related documentation outside the terms of the EULA
 # is strictly prohibited.
 
+from cuda import cuda
 from cuda.core.experimental._memory import Buffer, MemoryResource
 from cuda.core.experimental._device import Device
-from cuda import cuda
 from cuda.core.experimental._utils import handle_return
 import ctypes
 import pytest
 
 class DummyDeviceMemoryResource(MemoryResource):
     def __init__(self, device):
         self.device = device
-        pass
 
     def allocate(self, size, stream=None) -> Buffer:
         ptr = handle_return(cuda.cuMemAlloc(size))
         return Buffer(ptr=ptr, size=size, mr=self)
 
     def deallocate(self, ptr, size, stream=None):
-        cuda.cuMemFree(ptr)
+        handle_return(cuda.cuMemFree(ptr))
 
     @property
     def is_device_accessible(self) -> bool:
@@ -65,14 +64,13 @@ def device_id(self) -> int:
 class DummyUnifiedMemoryResource(MemoryResource):
     def __init__(self, device):
         self.device = device
-        pass
 
     def allocate(self, size, stream=None) -> Buffer:
         ptr = handle_return(cuda.cuMemAllocManaged(size, cuda.CUmemAttach_flags.CU_MEM_ATTACH_GLOBAL.value))
         return Buffer(ptr=ptr, size=size, mr=self)
 
     def deallocate(self, ptr, size, stream=None):
-        cuda.cuMemFree(ptr)
+        handle_return(cuda.cuMemFree(ptr))
 
     @property
     def is_device_accessible(self) -> bool:
@@ -89,14 +87,13 @@ def device_id(self) -> int:
 class DummyPinnedMemoryResource(MemoryResource):
     def __init__(self, device):
         self.device = device
-        pass
 
     def allocate(self, size, stream=None) -> Buffer:
         ptr = handle_return(cuda.cuMemAllocHost(size))
         return Buffer(ptr=ptr, size=size, mr=self)
 
     def deallocate(self, ptr, size, stream=None):
-        cuda.cuMemFreeHost(ptr)
+        handle_return(cuda.cuMemFreeHost(ptr))
 
     @property
     def is_device_accessible(self) -> bool:
@@ -199,4 +196,3 @@ def test_buffer_close():
     buffer_close(DummyUnifiedMemoryResource(device))
     buffer_close(DummyPinnedMemoryResource(device))
 
-test_buffer_copy_to()

cuda_core/tests/test_module.py

@@ -1,4 +1,4 @@
-# Copyright 2021-2024 NVIDIA Corporation.  All rights reserved.
+# Copyright 2024 NVIDIA Corporation.  All rights reserved.
 #
 # Please refer to the NVIDIA end user license agreement (EULA) associated
 # with this source code for terms and conditions that govern your use of

cuda_core/tests/test_program.py

@@ -1,18 +1,16 @@
-# Copyright 2021-2024 NVIDIA Corporation.  All rights reserved.
+# Copyright 2024 NVIDIA Corporation.  All rights reserved.
 #
 # Please refer to the NVIDIA end user license agreement (EULA) associated
 # with this source code for terms and conditions that govern your use of
 # this software. Any use, reproduction, disclosure, or distribution of
 # this software and related documentation outside the terms of the EULA
 # is strictly prohibited.
 
-from cuda import nvrtc
 from cuda.core.experimental._program import Program
 from cuda.core.experimental._module import ObjectCode, Kernel
 from cuda.core.experimental._device import Device
 import pytest
 
-
 def test_program_init_valid_code_type():
     code = "extern \"C\" __global__ void my_kernel() {}"
     program = Program(code, "c++")
@@ -29,13 +27,13 @@ def test_program_init_invalid_code_format():
     with pytest.raises(TypeError):
         Program(code, "c++")
 
-# def test_program_compile_valid_target_type():
-#     code = "extern \"C\" __global__ void my_kernel() {}"
-#     program = Program(code, "c++")
-#     object_code = program.compile("ptx")
-#     kernel = object_code.get_kernel("my_kernel")
-#     assert isinstance(object_code, ObjectCode)
-#     assert isinstance(kernel, Kernel)
+def test_program_compile_valid_target_type():
+    code = "extern \"C\" __global__ void my_kernel() {}"
+    program = Program(code, "c++")
+    object_code = program.compile("ptx")
+    kernel = object_code.get_kernel("my_kernel")
+    assert isinstance(object_code, ObjectCode)
+    assert isinstance(kernel, Kernel)
 
 def test_program_compile_invalid_target_type():
     code = "extern \"C\" __global__ void my_kernel() {}"
@@ -58,4 +56,3 @@ def test_program_close():
     program = Program(code, "c++")
     program.close()
     assert program.handle is None
-    

cuda_core/tests/test_stream.py

@@ -1,4 +1,4 @@
-# Copyright 2021-2024 NVIDIA Corporation.  All rights reserved.
+# Copyright 2024 NVIDIA Corporation.  All rights reserved.
 #
 # Please refer to the NVIDIA end user license agreement (EULA) associated
 # with this source code for terms and conditions that govern your use of
@@ -84,4 +84,3 @@ def test_per_thread_default_stream():
 def test_default_stream():
     stream = default_stream()
     assert isinstance(stream, Stream)
-