Skip to content

Flip kernel and config positions in launch() #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leofang opened this issue Dec 16, 2024 · 2 comments · Fixed by #316
Closed

Flip kernel and config positions in launch() #306

leofang opened this issue Dec 16, 2024 · 2 comments · Fixed by #316
Assignees
@ksimpson-work
Labels
breaking Breaking changes are introduced cuda.core Everything related to the cuda.core module triage Needs the team's attention

Comments

@leofang
Copy link
Member

leofang commented Dec 16, 2024

To match what cuda::experimental::launch() does.
@leofang leofang added breaking Breaking changes are introduced cuda.core Everything related to the cuda.core module P0 High priority - Must do! labels Dec 16, 2024
@leofang leofang added this to the cuda.core beta 3 milestone Dec 16, 2024
@ksimpson-work ksimpson-work self-assigned this Dec 19, 2024
@ksimpson-work ksimpson-work mentioned this issue Dec 19, 2024
Merged
@leofang

This comment has been minimized.

Sign in to view
@leofang leofang added triage Needs the team's attention and removed P0 High priority - Must do! labels Feb 20, 2025
@leofang leofang removed this from the cuda.core beta 3 milestone Feb 20, 2025
@leofang
Copy link
Member Author

leofang commented Mar 1, 2025

xref: #316 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksimpson-work ksimpson-work

Labels
breaking Breaking changes are introduced cuda.core Everything related to the cuda.core module triage Needs the team's attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch the launch argument order ksimpson-work/cuda-python
2 participants
@leofang @ksimpson-work