Skip to content

revise the handling of backend and handle properties in Program #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ksimpson-work opened this issue Feb 3, 2025 · 3 comments · Fixed by #463
Closed

revise the handling of backend and handle properties in Program #433

ksimpson-work opened this issue Feb 3, 2025 · 3 comments · Fixed by #463
Assignees
Labels
cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P0 High priority - Must do!

Comments

@ksimpson-work
Copy link
Contributor

ksimpson-work commented Feb 3, 2025

Program is either backed by nvrtc (cuda-bindings), or the Linker object (cuda-core abstraction).

Come up with, and implement a scheme for the Program.handle and Program.backend slots whose return values are currently ill defined and vary depending on the Program's backend.

see thread #317 (comment)

@ksimpson-work ksimpson-work added cuda.core Everything related to the cuda.core module P0 High priority - Must do! labels Feb 3, 2025
@ksimpson-work ksimpson-work added this to the cuda.core beta 3 milestone Feb 3, 2025
@ksimpson-work
Copy link
Contributor Author

We should talk about this in the thursday cuda.core meeting. Specifically the implications to #370 and #192 are potentially noteworthy

@leofang
Copy link
Member

leofang commented Feb 4, 2025

btw in the original design, .handle/.from_handle() are meant for C-Python interoperability, where we can take a handle from cuda.core and pass it to a foreign C library, or vice versa. It seems with #370 we might start making the story more complicated than necessary. I need to think about it while working on #180/#370.

@ksimpson-work
Copy link
Contributor Author

copy that

@leofang leofang added the triage Needs the team's attention label Feb 12, 2025
@leofang leofang self-assigned this Feb 18, 2025
@leofang leofang added enhancement Any code-related improvements and removed triage Needs the team's attention labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants