Merge pull request #1513 from NativeScript/darind/inspector-worker-console

fix: console.log in worker should not crash app (#1511)

Author: darind

test-app/runtime/src/main/cpp/JsV8InspectorClient.cpp

@@ -233,12 +233,11 @@ void JsV8InspectorClient::sendToFrontEndCallback(const v8::FunctionCallbackInfo<
     }
 }
 
-void JsV8InspectorClient::consoleLogCallback(const string& message, const string& logLevel) {
+void JsV8InspectorClient::consoleLogCallback(Isolate* isolate, const string& message, const string& logLevel) {
     if (!inspectorIsConnected()) {
         return;
     }
 
-    auto isolate = Runtime::GetRuntime(0)->GetIsolate();
     auto stack = v8::StackTrace::CurrentStackTrace(isolate, 1, v8::StackTrace::StackTraceOptions::kDetailed);
 
     auto frame = stack->GetFrame(isolate, 0);

test-app/runtime/src/main/cpp/JsV8InspectorClient.h

@@ -33,7 +33,7 @@ class JsV8InspectorClient : V8InspectorClient, v8_inspector::V8Inspector::Channe
         void flushProtocolNotifications() override;
 
         static void sendToFrontEndCallback(const v8::FunctionCallbackInfo<v8::Value>& args);
-        static void consoleLogCallback(const std::string& message, const std::string& logLevel);
+        static void consoleLogCallback(v8::Isolate* isolate, const std::string& message, const std::string& logLevel);
 
         void runMessageLoopOnPause(int context_group_id) override;
         void quitMessageLoopOnPause() override;

test-app/runtime/src/main/cpp/console/Console.cpp

@@ -69,7 +69,7 @@ void Console::sendToADBLogcat(const std::string& message, android_LogPriority lo
 
 void Console::sendToDevToolsFrontEnd(v8::Isolate* isolate, const std::string& message, const std::string& logLevel) {
     if (m_callback != nullptr) {
-        m_callback(message, logLevel);
+        m_callback(isolate, message, logLevel);
     }
 }
 

test-app/runtime/src/main/cpp/console/Console.h

@@ -11,7 +11,7 @@
 
 namespace tns {
 
-typedef void (*ConsoleCallback)(const std::string& message, const std::string& logLevel);
+typedef void (*ConsoleCallback)(v8::Isolate* isolate, const std::string& message, const std::string& logLevel);
 
 class Console {
     public: