Skip to content

Commit edf706a

Browse files
authored
Merge pull request #1389 from NativeScript/trifonov/gradle-3.4.1
update android gradle
2 parents 6e16bf2 + 0d21011 commit edf706a

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

build-artifacts/scripts/release-notes.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ function getCredentials() {
5656
function listMilestones() {
5757

5858
console.log("Request open milestones.");
59-
milestoneRequest.headers.Authorization = "Basic " + new Buffer(username + ":" + password).toString("base64");
59+
milestoneRequest.headers.Authorization = "Basic " + Buffer.from(username + ":" + password).toString("base64");
6060

6161
var req = https.request(milestoneRequest, gitHubResponse(function (data) {
6262

@@ -106,11 +106,11 @@ function selectMilestone() {
106106
}
107107

108108
function createReleaseNotes(milestone) {
109-
109+
110110
console.log("Request closed issues in the milestone.");
111-
issuesRequest.headers.Authorization = "Basic " + new Buffer(username + ":" + password).toString("base64");
111+
issuesRequest.headers.Authorization = "Basic " + Buffer.from(username + ":" + password).toString("base64");
112112
issuesRequest.path = '/repos/NativeScript/android-runtime/issues?milestone=' + milestone.number + '&state=closed';
113-
113+
114114
var req = https.request(issuesRequest, gitHubResponse(function (data) {
115115

116116
if (!(data instanceof Array)) {
@@ -131,7 +131,7 @@ function createReleaseNotes(milestone) {
131131
return l.name == "feature";
132132
}).length > 0;
133133
});
134-
134+
135135
var performance = issues.filter(function (i) {
136136
return i.labels.filter(function (l) {
137137
return l.name == "T:Performance";

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
],
1212
"gradle": {
1313
"version": "5.1.1",
14-
"android": "3.4.0"
14+
"android": "3.4.1"
1515
},
1616
"android_ndk_version": "19c"
1717
}

test-app/build-tools/android-metadata-generator/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ buildscript {
1717
}
1818

1919
dependencies {
20-
classpath 'com.android.tools.build:gradle:3.4.0'
20+
classpath 'com.android.tools.build:gradle:3.4.1'
2121
}
2222
}
2323

test-app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ buildscript {
77
jcenter()
88
}
99
dependencies {
10-
classpath 'com.android.tools.build:gradle:3.4.0'
10+
classpath 'com.android.tools.build:gradle:3.4.1'
1111
}
1212
}
1313

0 commit comments

Comments
 (0)