Fix tns debug ios issues

Since we use the ios-device-lib to connect to the device backend port for debugging, the socket returned from the device can be used only in the ios-device lib.
That's why we need to change the logic for creating the Node.js socket in the CLI. The ios-device-lib will expose the device socket on a specific port in the localhost.
After we connect to the exposed socket we can continue to work like we used to.

Author: TsvetanMilanov

lib/common

@@ -290,7 +290,7 @@ interface IAndroidToolsInfoData {
 
 interface ISocketProxyFactory {
 	createTCPSocketProxy(factory: () => any): any;
-	createWebSocketProxy(factory: () => any): any;
+	createWebSocketProxy(factory: () => Promise<any>): any;
 }
 
 interface IiOSNotification {

lib/declarations.ts

@@ -67,7 +67,6 @@ export class SocketProxyFactory implements ISocketProxyFactory {
 	}
 
 	public createWebSocketProxy(factory: () => Promise<net.Socket>): ws.Server {
-		let socketFactory = async (callback: (_socket: net.Socket) => void) => callback(await factory());
 		// NOTE: We will try to provide command line options to select ports, at least on the localhost.
 		let localPort = 8080;
 
@@ -80,13 +79,12 @@ export class SocketProxyFactory implements ISocketProxyFactory {
 
 		let server = new ws.Server(<any>{
 			port: localPort,
-			verifyClient: (info: any, callback: Function) => {
+			verifyClient: async (info: any, callback: Function) => {
 				this.$logger.info("Frontend client connected.");
-				socketFactory((_socket: any) => {
-					this.$logger.info("Backend socket created.");
-					info.req["__deviceSocket"] = _socket;
-					callback(true);
-				});
+				const _socket = await factory();
+				this.$logger.info("Backend socket created.");
+				info.req["__deviceSocket"] = _socket;
+				callback(true);
 			}
 		});
 		server.on("connection", (webSocket) => {
@@ -102,9 +100,10 @@ export class SocketProxyFactory implements ISocketProxyFactory {
 
 			webSocket.on("message", (message, flags) => {
 				let length = Buffer.byteLength(message, encoding);
-				let payload = new Buffer(length);
-				payload.write(message, 0, length, encoding);
-				deviceSocket.write(payload.toString());
+				let payload = new Buffer(length + 4);
+				payload.writeInt32BE(length, 0);
+				payload.write(message, 4, length, encoding);
+				deviceSocket.write(payload);
 			});
 
 			deviceSocket.on("end", () => {

lib/device-sockets/ios/socket-proxy-factory.ts

@@ -18,9 +18,12 @@ export class IOSSocketRequestExecutor implements IiOSSocketRequestExecutor {
 			await this.$iOSNotificationService.postNotification(deviceIdentifier, this.$iOSNotification.getAttachAvailable(projectId), constants.IOS_OBSERVE_NOTIFICATION_COMMAND_TYPE)
 		];
 
-		const observeNotificationPromises = _.map(observeNotificationSockets, s => {
-			return this.$iOSNotificationService.awaitNotification(deviceIdentifier, +s, timeout);
-		});
+		const observeNotificationPromises = _(observeNotificationSockets)
+			.uniq()
+			.map(s => {
+				return this.$iOSNotificationService.awaitNotification(deviceIdentifier, +s, timeout);
+			})
+			.value();
 
 		// Trigger the notifications update.
 		await this.$iOSNotificationService.postNotification(deviceIdentifier, this.$iOSNotification.getAttachAvailabilityQuery(projectId));

lib/device-sockets/ios/socket-request-executor.ts

@@ -174,20 +174,12 @@ class IOSDebugService implements IDebugService {
 	}
 
 	private async wireDebuggerClient(projectData: IProjectData, device?: Mobile.IiOSDevice): Promise<void> {
-		const factoryPromise = async () => {
+		const factory = async () => {
 			let socket = device ? await device.connectToPort(inspectorBackendPort) : net.connect(inspectorBackendPort);
 			this._sockets.push(socket);
 			return socket;
 		};
-
-		const socket = await factoryPromise();
-		const factory = () => {
-			process.nextTick(() => {
-				socket.emit("connect");
-			});
-			return socket;
-		};
-
+		
 		if (this.$options.chrome) {
 			this._socketProxy = this.$socketProxyFactory.createWebSocketProxy(factory);