Merge pull request #35 from NativeScript/vladimirov/java-8+

feat: Allow using JAVA 8+

Author: rosen-vladimirov

lib/android-tools-info.ts

@@ -14,7 +14,6 @@ export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
 	private static REQUIRED_BUILD_TOOLS_RANGE_PREFIX = ">=23";
 	private static VERSION_REGEX = /((\d+\.){2}\d+)/;
 	private static MIN_JAVA_VERSION = "1.8.0";
-	private static MAX_JAVA_VERSION = "1.9.0";
 
 	private toolsInfo: NativeScriptDoctor.IAndroidToolsInfoData;
 	private androidHome = process.env["ANDROID_HOME"];
@@ -103,8 +102,6 @@ export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
 
 			if (semver.lt(installedJavaCompilerSemverVersion, AndroidToolsInfo.MIN_JAVA_VERSION)) {
 				warning = `Javac version ${installedJavaCompilerVersion} is not supported. You have to install at least ${AndroidToolsInfo.MIN_JAVA_VERSION}.`;
-			} else if (semver.gte(installedJavaCompilerSemverVersion, AndroidToolsInfo.MAX_JAVA_VERSION)) {
-				warning = `Javac version ${installedJavaCompilerVersion} is not supported. You have to install version ${AndroidToolsInfo.MIN_JAVA_VERSION}.`;
 			}
 
 			if (warning) {

lib/wrappers/child-process.ts

@@ -78,7 +78,7 @@ export class ChildProcess {
 
 	public execFile(command: string, args: string[]): Promise<any> {
 		return new Promise<any>((resolve, reject) => {
-			childProcess.execFile(command, args, (error: any, stdout: NodeBuffer) => {
+			childProcess.execFile(command, args, (error, stdout) => {
 				if (error) {
 					reject(error);
 				} else {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "nativescript-doctor",
-  "version": "0.12.0",
+  "version": "1.0.0",
   "description": "Library that helps identifying if the environment can be used for development of {N} apps.",
   "main": "lib/index.js",
   "types": "./typings/nativescript-doctor.d.ts",

test/android-tools-info.ts

@@ -34,12 +34,16 @@ describe("androidToolsInfo", () => {
 				javacVersion: "1.8.0_152"
 			},
 			{
-				javacVersion: "9",
-				warnings: ["Javac version 9 is not supported. You have to install version 1.8.0."]
+				javacVersion: "9"
 			},
 			{
-				javacVersion: "9.0.1",
-				warnings: ["Javac version 9.0.1 is not supported. You have to install version 1.8.0."]
+				javacVersion: "9.0.1"
+			},
+			{
+				javacVersion: "10"
+			},
+			{
+				javacVersion: "10.0.1"
 			},
 			{
 				javacVersion: "1.7.0",