-
-
Notifications
You must be signed in to change notification settings - Fork 197
CLI run/debug commands should detect the type of device #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In Android emulator and device are both devices, so with one emulator and one device you also can not make a decision. |
First lets say that there is a way to make a distinction between android device and android emulator. Lets paraphrase this issue to be more clear.
@dtopuzov Android Studio has one button to debug an application (not separate buttons for emulators and devices), thus showing a combined UI with all emulators and devices connected. Android Studio is not the best example in our case. The better example is adb where: The problem manifests itself mostly in VS code where we have a UI for specifying emulator and device separately, ie "Launch on Android Device" and "Launch on Android Emulator". Currently there is a way to specify the deviceId with tnsArgs in launch.config json by manually editing the file. But having that the developer has one device and one emulator most of the time we should improve the experience. Having said this it is worth mentioning this is a usability improvement feature which will greatly ease the developer. Hope this clears the confusion a bit. |
After short discussion we decided to close this. The --emulator option will be depreciated soon and visual studio code {N} extension will have "Launch on Android" option only. This will start the app on the SINGLE available emulator or device or will fail if multiple devices are present. There is always an option to specify the target device using tnsArgs in launch.json file when multiple devices are connected. This will be on par with how CLI handles these cases. closing this issue. |
When run/debug command is started it should detect the type of device and make the device Id optional in cases when only one device and one emulator is found.
--emulator and --device should detect the devices connected and ask for device id only when a decision can not be made.
The text was updated successfully, but these errors were encountered: