Skip to content

[Android] CLI 3.4.0 fails to bundle app with older runtimes/core modules #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PeterStaev opened this issue Dec 28, 2017 · 4 comments
Closed
Labels

Comments

@PeterStaev
Copy link
Contributor

Did you verify this is a real problem by searching Stack Overflow and the other open issues in this repo?

Yes

Tell us about the problem

Till now it was ok to use newer CLI version with old runtime/core modules so you can build/bundle an app. But with 3.4.0 especially for android this seems to be broken.

Which platform(s) does your issue occur on?

Android

Please provide the following version numbers that your issue occurs with:

  • CLI: 3.4.0
  • Cross-platform modules: 3.2.0
  • Runtime(s): 3.2.0
  • nativescript-dev-webpack: 0.8.0

Please tell us how to recreate the issue in as much detail as possible.

The issue is reproducible in the DropDown demo project. Here is also a link to the error happening on TravisCI: https://travis-ci.org/PeterStaev/NativeScript-Drop-Down/jobs/322513345#L3763

@NickIliev
Copy link
Contributor

Hi @PeterStaev

This behavior is due to the breaking changes introduced with this feature in android-runtime and this related PR in nativescript-dev-webpack

@PeterStaev
Copy link
Contributor Author

Ok, but nonetheless CLI should maintain compatibility between versions no matter the changes. Otherwise it makes the verified plugin CI Cron jobs a bit w/o much sense if I have to upgrade the demo apps for every new CLI version that comes out. Not to mention that this is is minor version increase, hence full 3.0+ compatibility must be maintained.

Not to mention that if I have production apps running on 3.3 that I do not want to upgrade but also I'm developing new apps on 3.4, I'm forced to constantly switch between CLI versions because of this problem.

@ddfreiling
Copy link

Just ran into this when trying to bundle a new version of our app with latest CLI. We haven't made the upgrade to tns-core-modules 3.4 and newest webpack yet, so it would have been nice with a warning about this breaking change of the CLI in the 3.4 Changelog.

@rosen-vladimirov
Copy link
Contributor

Hey guys,
As this issue is quite old and related to old CLI versions, I think we can close it. I agree the situation at the point when the issue was created was not handled well, but in the recent releases we've learnt our lesson and we've tried to ensure CLI can build older projects. Of course, when there are some major release, this could change, but only in this cases. Ping me in case you have some concerns and I'll reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants