Skip to content

Commit b7f3131

Browse files
committed
fix: do not add @nativescript/schematics dependency manually
fixes #279
1 parent a8b1bca commit b7f3131

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

package.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@
1515
"lint": "tslint --project ./tsconfig.json -c ./tslint.json 'src/**/*.ts'",
1616
"lint:fix": "tslint --project ./tsconfig.json -c ./tslint.json 'src/**/*.ts' --fix"
1717
},
18+
"ng-add": {
19+
"save": "devDependencies"
20+
},
21+
"ng-new": {
22+
"save": "devDependencies"
23+
},
1824
"schematics": "./src/collection.json",
1925
"dependencies": {
2026
"@angular-devkit/core": "~9.1.0",

src/add-ns/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,6 @@ const addDependencies = () => (tree: Tree, context: SchematicContext) => {
374374

375375
const devDepsToAdd = {
376376
'nativescript-dev-webpack': '~1.5.0',
377-
'@nativescript/schematics': '~2.0.0',
378377
'@nativescript/tslint-rules': '~0.0.5',
379378
};
380379
packageJson.devDependencies = {...devDepsToAdd, ...packageJson.devDependencies};

src/add-ns/index_spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ describe('Add {N} schematic', () => {
8484
expect(dependencies['reflect-metadata']).toBeDefined();
8585

8686
expect(devDependencies['nativescript-dev-webpack']).toBeDefined();
87-
expect(devDependencies['@nativescript/schematics']).toBeDefined();
8887
expect(devDependencies['@nativescript/tslint-rules']).toBeDefined();
8988
});
9089

src/ng-new/application/_files/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@
2525
"devDependencies": {
2626
"@angular/cli": "~9.1.0",
2727
"@angular/compiler-cli": "~9.1.0",
28-
"@angular-devkit/core": "~9.1.0",
29-
"@nativescript/schematics": "~2.0.0",<% if(webpack) { %>
28+
"@angular-devkit/core": "~9.1.0",<% if(webpack) { %>
3029
"nativescript-dev-webpack": "~1.5.0",
3130
"@ngtools/webpack": "~9.1.0",
3231
<% } %>"typescript": "~3.8.3"

src/ng-new/shared/_files/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
"@angular/cli": "~9.1.0",
4040
"@angular/compiler-cli": "~9.1.0",
4141
"@angular-devkit/build-angular": "~0.901.0",
42-
"@nativescript/schematics": "~2.0.0",
4342
"@nativescript/tslint-rules": "~0.0.5",
4443
"@types/jasmine": "~3.5.0",
4544
"@types/jasminewd2": "~2.0.3",

0 commit comments

Comments
 (0)