Skip to content

Commit 211c6c5

Browse files
authored
fix: check for snapshot skipped (#386)
* check for snapshot skipped message only in rc * fix lint * remove snapshot skipped check from tests * remove unused imports
1 parent e4d4762 commit 211c6c5

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

data/sync/hello_world_js.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ def run_hello_world_js_ts(app_name, platform, device, bundle=True, hmr=True, ugl
4141
result = Tns.run(app_name=app_name, platform=platform, emulator=True, wait=False, bundle=bundle, hmr=hmr,
4242
release=release, uglify=uglify, aot=aot, snapshot=snapshot, sync_all_files=sync_all_files,
4343
just_launch=just_launch)
44-
TnsAssert.snapshot_skipped(snapshot, result, release)
4544

4645
strings = TnsLogs.run_messages(app_name=app_name, platform=platform, run_type=RunType.UNKNOWN, bundle=bundle,
4746
hmr=hmr, instrumented=instrumented, device=device, release=release,

data/sync/hello_world_ng.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from products.nativescript.run_type import RunType
1515
from products.nativescript.tns import Tns
1616
from products.nativescript.tns_logs import TnsLogs
17-
from products.nativescript.tns_assert import TnsAssert
1817

1918

2019
def run_hello_world_ng(app_name, platform, device, bundle=True, uglify=False, aot=False, hmr=True,
@@ -29,7 +28,6 @@ def run_hello_world_ng(app_name, platform, device, bundle=True, uglify=False, ao
2928
# Execute tns run command
3029
result = Tns.run(app_name=app_name, platform=platform, emulator=emulator, bundle=bundle, aot=aot,
3130
uglify=uglify, hmr=hmr, release=release, snapshot=snapshot, device=device_id)
32-
TnsAssert.snapshot_skipped(snapshot, result, release)
3331

3432
# Check logs
3533
strings = TnsLogs.run_messages(app_name=app_name, platform=platform, run_type=RunType.UNKNOWN, bundle=bundle,

data/sync/master_details_ng.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,12 @@
1313
from data.changes import Changes, Sync
1414
from data.const import Colors
1515
from products.nativescript.tns import Tns
16-
from products.nativescript.tns_assert import TnsAssert
1716

1817

1918
def run_master_detail_ng(app_name, platform, device, bundle=True, hmr=True, uglify=False, aot=False,
2019
release=False, snapshot=False):
2120
result = Tns.run(app_name=app_name, platform=platform, emulator=True, wait=False, bundle=bundle,
2221
hmr=hmr, aot=aot, uglify=uglify, snapshot=snapshot, release=release)
23-
TnsAssert.snapshot_skipped(snapshot, result, release)
2422

2523
# Verify it looks properly
2624
device.wait_for_text(text=Changes.MasterDetailNG.TS.old_text, timeout=450, retry_delay=5)

0 commit comments

Comments
 (0)