Skip to content

When an access list is selected containing only access rules and no authorizations, it should only include the rules in the proxy config and not the authorization #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geertmeersman opened this issue May 22, 2020 · 2 comments

Comments

@geertmeersman
Copy link

Hi,

when creating an access list containing just access rules and no authorization, the proxy host template still included the section

    {% if access_list_id > 0 %}
    # Authorization
    auth_basic            "Authorization required";
    auth_basic_user_file  /data/access/{{ access_list_id }};

I would like to only see the # Access Rules part being populated.

  • What version of Nginx Proxy Manager is reported on the login page? 2.2.4

To Reproduce
Steps to reproduce the behavior:

  1. Go to Access Lists
  2. Click on 'Add Access List'
  3. Provide a name and in the 'Access section' provide some IP addresses to allow
  4. Save
  5. Add the Access list to a proxy host

Expected behavior
The proxy host should not pop up a basic authentication popup in the browser since no names/passwords were provided

Screenshots
Auth Popup

Additional context
I now always delete the lines in the generated proxy host, but it would be perfect if this would be handled in the template.

@Nedlinin
Copy link

☝️ Definitely would like to see this one fixed.

Copy link

Issue is now considered stale. If you want to keep it open, please comment 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants