Skip to content

2.3.0 - Access list allow rules not applying to nginx config files. #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chewza opened this issue May 29, 2020 · 2 comments
Closed

2.3.0 - Access list allow rules not applying to nginx config files. #434

Chewza opened this issue May 29, 2020 · 2 comments
Labels

Comments

@Chewza
Copy link

Chewza commented May 29, 2020

Checklist

  • Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
    Yes
  • Are you sure you're not using someone else's docker image?
    Yes
  • If having problems with Lets Encrypt, have you made absolutely sure your site is accessible from outside of your network?
    Yes

Describe the bug
2.3.0 does not apply the ALLOWED IP access lists to the individual nginx config files.

To Reproduce
Steps to reproduce the behavior:

  1. Create access list with IP address with ALLOW rule.
  2. Attach rule to proxy_host
  3. Observe that no Allow rule is created above the deny all rule.

Expected behavior
Specified allow rules should apply above the default deny all;

Issue not present in 2.2.4 branch.

@Subv
Copy link
Contributor

Subv commented May 30, 2020

Could you try #435 please? it seems to fix the issue

@cmitz
Copy link

cmitz commented Jun 5, 2020

Can confirm #435 fixes this issue

@jc21 jc21 closed this as completed in d95861e Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants