Skip to content

Commit 63d7085

Browse files
committed
Fixing tests and analyze issues after merging in master
* Add WidgetTester to some existing tests * Update SDK constraints per analyze issue
1 parent 578321b commit 63d7085

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

packages/webview_flutter/example/integration_test/webview_flutter_test.dart

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ import 'package:flutter/foundation.dart';
1111
import 'package:flutter/services.dart';
1212
import 'package:flutter/widgets.dart';
1313
import 'package:flutter_test/flutter_test.dart';
14+
import 'package:integration_test/integration_test.dart';
1415
import 'package:webview_flutter/platform_interface.dart';
1516
import 'package:webview_flutter/webview_flutter.dart';
16-
import 'package:integration_test/integration_test.dart';
1717

1818
void main() {
1919
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
@@ -358,12 +358,12 @@ void main() {
358358
videoTestBase64 = base64Encode(const Utf8Encoder().convert(videoTest));
359359
});
360360

361-
test('Auto media playback', () async {
361+
testWidgets('Auto media playback', (WidgetTester tester) async {
362362
Completer<WebViewController> controllerCompleter =
363363
Completer<WebViewController>();
364364
Completer<void> pageLoaded = Completer<void>();
365365

366-
await pumpWidget(
366+
await tester.pumpWidget(
367367
Directionality(
368368
textDirection: TextDirection.ltr,
369369
child: WebView(
@@ -390,7 +390,7 @@ void main() {
390390
pageLoaded = Completer<void>();
391391

392392
// We change the key to re-create a new webview as we change the initialMediaPlaybackPolicy
393-
await pumpWidget(
393+
await tester.pumpWidget(
394394
Directionality(
395395
textDirection: TextDirection.ltr,
396396
child: WebView(
@@ -416,13 +416,14 @@ void main() {
416416
expect(isPaused, _webviewBool(true));
417417
});
418418

419-
test('Changes to initialMediaPlaybackPolicy are ignored', () async {
419+
testWidgets('Changes to initialMediaPlaybackPolicy are ignored',
420+
(WidgetTester tester) async {
420421
final Completer<WebViewController> controllerCompleter =
421422
Completer<WebViewController>();
422423
Completer<void> pageLoaded = Completer<void>();
423424

424425
final GlobalKey key = GlobalKey();
425-
await pumpWidget(
426+
await tester.pumpWidget(
426427
Directionality(
427428
textDirection: TextDirection.ltr,
428429
child: WebView(
@@ -447,7 +448,7 @@ void main() {
447448

448449
pageLoaded = Completer<void>();
449450

450-
await pumpWidget(
451+
await tester.pumpWidget(
451452
Directionality(
452453
textDirection: TextDirection.ltr,
453454
child: WebView(
@@ -474,12 +475,13 @@ void main() {
474475
expect(isPaused, _webviewBool(false));
475476
});
476477

477-
test('Video plays inline when allowsInlineMediaPlayback is true', () async {
478+
testWidgets('Video plays inline when allowsInlineMediaPlayback is true',
479+
(WidgetTester tester) async {
478480
Completer<WebViewController> controllerCompleter =
479481
Completer<WebViewController>();
480482
Completer<void> pageLoaded = Completer<void>();
481483

482-
await pumpWidget(
484+
await tester.pumpWidget(
483485
Directionality(
484486
textDirection: TextDirection.ltr,
485487
child: WebView(
@@ -507,7 +509,7 @@ void main() {
507509
controllerCompleter = Completer<WebViewController>();
508510
pageLoaded = Completer<void>();
509511

510-
await pumpWidget(
512+
await tester.pumpWidget(
511513
Directionality(
512514
textDirection: TextDirection.ltr,
513515
child: WebView(

packages/webview_flutter/example/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: webview_flutter_example
22
description: Demonstrates how to use the webview_flutter plugin.
33

44
environment:
5-
sdk: ">=2.0.0-dev.68.0 <3.0.0"
5+
sdk: ">=2.2.0 <3.0.0"
66

77
dependencies:
88
flutter:

0 commit comments

Comments
 (0)