Skip to content

{bitmap,editres,fonttosfnt,iceauth,oclock}: refactor & move to pkgs/by-name from xorg namespace #464137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

{bitmap,editres,fonttosfnt,iceauth,oclock}: refactor & move to pkgs/by-name from xorg namespace #464137

wants to merge 5 commits into from
+297 −262

Conversation

@quantenzitrone
Copy link
Contributor

@quantenzitrone quantenzitrone commented Nov 22, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
      • pkgs
      • pkgsStatic (except bitmap, which is broken on static)
      • pkgsCross.aarch64-multiplatform
      • pkgsCross.aarch64-multiplatform.pkgsStatic (except bitmap)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
    • bitmap (-version & -help output, i don't know how to use this program)
    • editres
    • fonttosfnt (converting one pcf font)
    • iceauth (through xwayland, just the help and info output, idc enough to understand iceauthority to test this properly)
    • oclock
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@quantenzitrone quantenzitrone changed the title {bitmap,editres,fonttosfnt,iceauth,oclock}: refactor & move to pkgs/by-name from xorg namespace @quantenzitrone {bitmap,editres,fonttosfnt,iceauth,oclock}: refactor & move to pkgs/by-name from xorg namespace Nov 22, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. labels Nov 22, 2025
@quantenzitrone quantenzitrone marked this pull request as draft November 23, 2025 00:02
@quantenzitrone quantenzitrone marked this pull request as ready for review November 23, 2025 00:35
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 23, 2025
@quantenzitrone
Copy link
Contributor Author

quantenzitrone commented Nov 23, 2025

nixpkgs/nixos/modules/services/x11/xserver.nix

Line 838 in 1f567ec

xorg.iceauth # required for KDE applications (it's called by dcopserver)

hmm, i think iceauth needs proper testing

@quantenzitrone
Copy link
Contributor Author

quantenzitrone commented Nov 23, 2025 •
edited
Loading

eeek

$ git blame nixos/modules/services/x11/xserver.nix -L 838,838
Blaming lines: 100% (1/1), done.
6920f43f1cc6d modules/services/x11/xserver/default.nix (Eelco Dolstra 2009-09-10 12:37:33 +0000 838)         xorg.iceauth # required for KDE applications (it's called by dcopserver)

dcopserver hasn't been around since the end of kde3 (2008)

@quantenzitrone
Copy link
Contributor Author

quantenzitrone commented Nov 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 464137
Commit: 972e54f0326141fd0dd26745df110619ec5809f4

x86_64-linux

✅ 1 test built:
  • nixosTests.simple
✅ 51 packages built:
  • bitmap (xorg.bitmap)
  • calamares
  • calamares-nixos
  • calamares.debug
  • cherry
  • clearlyU
  • console-setup
  • creep
  • dina-font
  • dina-font.bdf
  • editres (xorg.editres)
  • efont-unicode
  • efont-unicode.bdf
  • envypn-font
  • fonttosfnt (xorg.fonttosfnt)
  • gohufont
  • grub2 (grub2_light)
  • grub2.debug (grub2_light.debug)
  • grub2_efi
  • grub2_efi.debug
  • grub2_pvgrub_image
  • grub2_pvhgrub_image
  • grub2_xen
  • grub2_xen_pvh
  • grub2_xen_pvh.debug
  • iceauth (xorg.iceauth)
  • oclock (xorg.oclock)
  • os-prober
  • siji
  • siji.bdf
  • tests.devShellTools.nixos
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example (tests.testers.runNixOSTest-extendNixOS)
  • tests.trivial-builders.references
  • tewi-font
  • timeshift
  • timeshift.man
  • ucs-fonts
  • ucs-fonts.bdf
  • uni-vga
  • uni-vga.bdf
  • unifont
  • uw-ttyp0
  • woeusb
  • woeusb-ng
  • woeusb-ng.dist
  • xfce.xfce4-session
  • xfce.xfce4-session.dev
  • xsm (xorg.xsm)
  • zutty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jopejoe1 jopejoe1 Awaiting requested review from jopejoe1

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@quantenzitrone