Skip to content

Commit 9ff4856

Browse files
chinmaygardeNoamDev
authored andcommitted
Remove buggy assertion in EmbedderTest::CanPostTaskToAllNativeThreads. (flutter-team-archive#16071)
This was introduced in flutter-team-archive@c5329ef. The assertion was originally written to check that more than 4 threads were managed by the engine (UI, Platform, GPU, IO + ConcurrentWQWorkers). However, the assertion actually only checked the count of workers in the ConcurrentWQ. As written, this assertion would fail on all hosts with a hardware concurrency of less than 4. Remove the assertion. The engine threads count and its assertions already check callbacks on workers. So this check was incorrect and redundant.
1 parent 165412a commit 9ff4856

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

shell/platform/embedder/tests/embedder_unittests.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3936,7 +3936,6 @@ TEST_F(EmbedderTest, CanPostTaskToAllNativeThreads) {
39363936

39373937
sync_latch.Wait();
39383938

3939-
ASSERT_GT(worker_count, 4u /* three base threads plus workers */);
39403939
const auto engine_threads_count = worker_count + 4u;
39413940

39423941
struct Captures {

0 commit comments

Comments
 (0)