chore: improve docs script and remove warnings (#1011)

Author: frangio

.github/scripts/cargo-doc.sh

@@ -1,22 +1,20 @@
 #!/bin/bash
 
-set -e
+set -euo pipefail
+
+edr_pkgs=($(
+  cargo metadata --format-version 1 --no-deps \
+  | jq -r '.packages[].name | select(startswith("edr_"))'
+))
+
+foundry_pkgs=($(
+  cargo metadata --format-version 1 --no-deps \
+  | jq -r --arg path "$PWD/crates/foundry/" \
+    '.packages[] | select(.manifest_path | startswith($path)) | .id'
+))
 
 # For EDR crates, test that docs build and they don't have warnings
-for dir in crates/edr_*/ ; do
-    if [ -d "$dir" ]; then
-      pushd "$dir" > /dev/null
-      RUSTDOCFLAGS="-D warnings" cargo doc --no-deps --all-features
-      popd > /dev/null
-    fi
-done
+RUSTDOCFLAGS="-D warnings" cargo doc --no-deps --all-features "${edr_pkgs[@]/#/--package=}"
 
 # For Foundry crates, only test that docs build and allow linking to private items
-for dir in crates/foundry/* ; do
-    if [ -d "$dir" ]; then
-      pushd "$dir" > /dev/null
-      cargo doc --all-features --no-deps --document-private-items
-      popd > /dev/null
-    fi
-done
-
+RUSTDOCFLAGS="-A warnings" cargo doc --no-deps --all-features --document-private-items "${foundry_pkgs[@]/#/--package=}"