File tree Expand file tree Collapse file tree 2 files changed +3
-7
lines changed
src/frontend/src/pages/ChangeRequestDetailPage Expand file tree Collapse file tree 2 files changed +3
-7
lines changed Original file line number Diff line number Diff line change @@ -19,7 +19,7 @@ interface ReviewChangeRequestProps {
1919}
2020
2121export interface FormInput {
22- reviewNotes : string ;
22+ reviewNotes ? : string ;
2323 accepted : boolean ;
2424 psId ?: string ;
2525}
@@ -45,7 +45,7 @@ const ReviewChangeRequest: React.FC<ReviewChangeRequestProps> = ({
4545 await mutateAsync ( {
4646 reviewerId : auth . user ?. userId ,
4747 crId,
48- reviewNotes,
48+ reviewNotes : reviewNotes ?? '' ,
4949 accepted,
5050 psId
5151 } ) . catch ( ( error ) => {
Original file line number Diff line number Diff line change @@ -39,7 +39,7 @@ interface ReviewChangeRequestViewProps {
3939}
4040
4141const schema = yup . object ( ) . shape ( {
42- reviewNotes : yup . string ( ) . required ( ) ,
42+ reviewNotes : yup . string ( ) ,
4343 accepted : yup . boolean ( ) . required ( ) ,
4444 psId : yup . string ( ) . optional ( )
4545} ) ;
@@ -169,7 +169,6 @@ const ReviewChangeRequestsView: React.FC<ReviewChangeRequestViewProps> = ({
169169 < Controller
170170 name = "reviewNotes"
171171 control = { control }
172- rules = { { required : true } }
173172 render = { ( { field : { onChange, value } } ) => (
174173 < >
175174 < Typography
@@ -183,7 +182,6 @@ const ReviewChangeRequestsView: React.FC<ReviewChangeRequestViewProps> = ({
183182 < TextField
184183 multiline
185184 rows = { 4 }
186- required
187185 variant = "outlined"
188186 id = "reviewNotes-input"
189187 autoComplete = "off"
@@ -246,14 +244,12 @@ const ReviewChangeRequestsView: React.FC<ReviewChangeRequestViewProps> = ({
246244 < Controller
247245 name = "reviewNotes"
248246 control = { control }
249- rules = { { required : true } }
250247 render = { ( { field : { onChange, value } } ) => (
251248 < >
252249 < Typography > { 'Additional Comments' } </ Typography >
253250 < TextField
254251 multiline
255252 rows = { 4 }
256- required
257253 id = "reviewNotes-input"
258254 autoComplete = "off"
259255 onChange = { onChange }
You can’t perform that action at this time.
0 commit comments