Unify PackageReferences checks

We were opt'ing CPS projects out of CpsProjectReferenceProjectProvider based on whether that had TargetFramework or TargetFrameworks properties, both are which are .NET-SDK specific.

C++/MSIX deployment and other custom projects don't have these properties.

Author: davkean

src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Projects/CpsPackageReferenceProjectProvider.cs

@@ -74,8 +74,9 @@ public async Task<NuGetProject> TryCreateNuGetProjectAsync(
                 return null;
             }
 
-            // Check if the project is not CPS capable or if it is CPS capable then it does not have TargetFramework(s), if so then return false
-            if (!VsHierarchyUtility.IsCPSCapabilityComplaint(hierarchy))
+            // Check if the project is not CPS capable or if it is CPS capable that its opt'd in PackageReferences
+            if (!VsHierarchyUtility.IsCPSCapabilityComplaint(hierarchy) &&
+                !VsHierarchyUtility.IsProjectCapabilityCompliant(hierarchy))
             {
                 return null;
             }
@@ -84,20 +85,13 @@ public async Task<NuGetProject> TryCreateNuGetProjectAsync(
 
             // read MSBuild property RestoreProjectStyle, TargetFramework, and TargetFrameworks
             var restoreProjectStyle = await buildProperties.GetPropertyValueAsync(ProjectBuildProperties.RestoreProjectStyle);
-            var targetFramework = await buildProperties.GetPropertyValueAsync(ProjectBuildProperties.TargetFramework);
-            var targetFrameworks = await buildProperties.GetPropertyValueAsync(ProjectBuildProperties.TargetFrameworks);
 
             // check for RestoreProjectStyle property is set and if not set to PackageReference then return false
             if (!(string.IsNullOrEmpty(restoreProjectStyle) ||
                 restoreProjectStyle.Equals(PackageReference, StringComparison.OrdinalIgnoreCase)))
             {
                 return null;
             }
-            // check whether TargetFramework or TargetFrameworks property is set, else return false
-            else if (string.IsNullOrEmpty(targetFramework) && string.IsNullOrEmpty(targetFrameworks))
-            {
-                return null;
-            }
 
             var fullProjectPath = vsProject.FullProjectPath;
             var unconfiguredProject = GetUnconfiguredProject(vsProject.Project);