Skip to content
This repository was archived by the owner on Mar 25, 2021. It is now read-only.

Commit 24d286d

Browse files
author
James Foster
authored
Fix test failures (#5)
1 parent 92a32d9 commit 24d286d

File tree

7 files changed

+14
-11
lines changed

7 files changed

+14
-11
lines changed

.arduino-ci.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ platforms:
1414
flags:
1515

1616
unittest:
17-
exclude_dirs:
18-
- "/Users/jfoster/Documents/Arduino/libraries/LiquidCrystal/test/"
1917
platforms:
2018
- mega2560
2119
libraries:

.github/workflows/Arduino-CI.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,12 @@ jobs:
2020
- run: |
2121
bundle install
2222
23+
# Creates the Library directory and install our libraries
24+
- run: |
25+
bundle exec ensure_arduino_installation.rb
26+
git clone https://github.com/Arduino-CI/LiquidCrystal.git
27+
mv LiquidCrystal $(bundle exec arduino_library_location.rb)
28+
2329
# Finally, run the tests
2430
- run: |
25-
bundle exec arduino_ci_remote.rb --skip-compilation
31+
bundle exec arduino_ci_remote.rb

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
source 'https://rubygems.org'
2-
gem 'arduino_ci'
2+
gem 'arduino_ci', git: 'https://github.com/ianfixes/arduino_ci.git', branch: '2020-10-16_suggestions'

examples/Blink/Blink.ino

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11

22
#include "TankControllerLib.h"
3-
TankControllerLib tank;
3+
TankControllerLib *tank = TankControllerLib::instance();
44

55
void setup() {
6-
tank.setup();
6+
tank->setup();
77
}
88
void loop() {
9-
tank.loop();
9+
tank->loop();
1010
}

library.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ author=James Foster <[email protected]>
44
maintainer=James Foster <[email protected]>
55
sentence=Software for the Arduino that controls pH and temperature in the Ocean Acidification project.
66
paragraph=
7-
category=Device Congtrol
7+
category=Device Control
88
url=https://github.com/Open-Acidification/TankControllerLib
9-
architectures=*
9+
architectures=avr

src/Devices/LiquidCrystal_TC.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
#include "LiquidCrystal_TC.h"
2-

src/Devices/LiquidCrystal_TC.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
class LiquidCrystal_TC {
99
private:
1010
const int RS = 24, EN = 22, D4 = 26, D5 = 28, D6 = 30, D7 = 32;
11-
LiquidCrystal* pLCD; // (RS, EN, D4, D5, D6, D7);
11+
LiquidCrystal* pLCD; // (RS, EN, D4, D5, D6, D7);
1212

1313
public:
1414
LiquidCrystal_TC();

0 commit comments

Comments
 (0)