|
1 | | - |
2 | 1 | # Contributing |
3 | 2 |
|
4 | | -I'm happy to accept external contributions to the project in the form of feedback, |
| 3 | +We are happy to accept external contributions to the project in the form of feedback, |
5 | 4 | bug reports and even better - pull requests |
6 | 5 |
|
7 | 6 | ## Issues |
8 | 7 |
|
9 | | -Issues are mostly used to track **bugs** and **feature requests** but you can also |
| 8 | +Issues are mostly used to track **bugs** and **feature requests** but you can also |
10 | 9 | ask questions as it's the only place I'm looking at. |
11 | 10 |
|
12 | 11 | Before reporting a bug or requesting a feature, run a few searches to |
13 | 12 | see if a similar issue has already been opened and ensure you’re not submitting |
14 | 13 | a duplicate. |
15 | 14 |
|
16 | 15 | ### Bugs |
17 | | -* Choose the "Bug Report" template |
18 | | -* Fill in all relevant information, especially |
19 | | -* Describe steps to reproduce |
20 | | -* Full error message if any |
21 | | -* Your code if relevant |
| 16 | + |
| 17 | +- Choose the "Bug Report" template |
| 18 | +- Fill in all relevant information, especially |
| 19 | +- Describe steps to reproduce |
| 20 | +- Full error message if any |
| 21 | +- Your code if relevant |
22 | 22 |
|
23 | 23 | ### Feature Requests |
24 | | -* Choose the "Feature Request" template |
25 | | -* Describe the feature. Be specific |
26 | | -* Explain why I should implement it. |
| 24 | + |
| 25 | +- Choose the "Feature Request" template |
| 26 | +- Describe the feature. Be specific |
| 27 | +- Explain why I should implement it. |
27 | 28 |
|
28 | 29 | ## Pull Request Guidelines |
29 | | -* Please check to make sure that there aren't existing pull requests attempting to address the issue mentioned. |
30 | | -* Open a single PR for each subject. |
31 | | -* Develop in a topic branch, not master (feature-name). |
32 | | -* Write a convincing description of your PR and why I should land it. |
33 | | -* Update documentation comments where applicable. |
| 30 | + |
| 31 | +- Please check to make sure that there aren't existing pull requests attempting to address the issue mentioned. |
| 32 | +- Open a single PR for each subject. |
| 33 | +- Develop in a topic branch, not master (feature-name). |
| 34 | +- Write a convincing description of your PR and why I should land it. |
| 35 | +- Update documentation comments where applicable. |
34 | 36 |
|
35 | 37 | ### Only touch relevant files |
36 | 38 |
|
37 | | -* Make sure your PR stays focused on a single feature. |
38 | | -* Don't change project configs or any files unrelated to the subject you're working. |
39 | | -* Don't reformat code you don't modify. |
| 39 | +- Make sure your PR stays focused on a single feature. |
| 40 | +- Don't change project configs or any files unrelated to the subject you're working. |
| 41 | +- Don't reformat code you don't modify. |
40 | 42 |
|
41 | 43 | ### Fixing a bug? |
42 | | -* Mention it or create an issue if not exist |
43 | | -* Do not forgot to put [Fix # in your commit message to auto close](https://help.github.com/articles/closing-issues-via-commit-messages/) |
| 44 | + |
| 45 | +- Mention it or create an issue if not exist |
| 46 | +- Do not forgot to put [Fix # in your commit message to auto close](https://help.github.com/articles/closing-issues-via-commit-messages/) |
44 | 47 |
|
45 | 48 | ### Keep your commit history short and clean. |
46 | | -* Keeping the history clean means making one commit per feature. (no fix of your fix) |
47 | | -* I will squash every PR. |
| 49 | + |
| 50 | +- Keeping the history clean means making one commit per feature. (no fix of your fix) |
| 51 | +- We may squash your PR. |
48 | 52 |
|
49 | 53 | ### Make sure tests pass (if exist) |
50 | | -* Add relevant tests to cover the change. |
51 | | -* Make sure test-suite passes. |
| 54 | + |
| 55 | +- Add relevant tests to cover the change. |
| 56 | +- Make sure test-suite passes. |
0 commit comments