Skip to content

Commit 45ce085

Browse files
magnus-karlssonanguy11
authored andcommitted
igc: add correct exception tracing for XDP
Add missing exception tracing to XDP when a number of different errors can occur. The support was only partial. Several errors where not logged which would confuse the user quite a lot not knowing where and why the packets disappeared. Fixes: 73f1071 ("igc: Add support for XDP_TX action") Fixes: 4ff3203 ("igc: Add support for XDP_REDIRECT action") Reported-by: Jesper Dangaard Brouer <[email protected]> Signed-off-by: Magnus Karlsson <[email protected]> Tested-by: Dvora Fuxbrumer <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent faae814 commit 45ce085

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

drivers/net/ethernet/intel/igc/igc_main.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2047,20 +2047,19 @@ static struct sk_buff *igc_xdp_run_prog(struct igc_adapter *adapter,
20472047
break;
20482048
case XDP_TX:
20492049
if (igc_xdp_xmit_back(adapter, xdp) < 0)
2050-
res = IGC_XDP_CONSUMED;
2051-
else
2052-
res = IGC_XDP_TX;
2050+
goto out_failure;
2051+
res = IGC_XDP_TX;
20532052
break;
20542053
case XDP_REDIRECT:
20552054
if (xdp_do_redirect(adapter->netdev, xdp, prog) < 0)
2056-
res = IGC_XDP_CONSUMED;
2057-
else
2058-
res = IGC_XDP_REDIRECT;
2055+
goto out_failure;
2056+
res = IGC_XDP_REDIRECT;
20592057
break;
20602058
default:
20612059
bpf_warn_invalid_xdp_action(act);
20622060
fallthrough;
20632061
case XDP_ABORTED:
2062+
out_failure:
20642063
trace_xdp_exception(adapter->netdev, prog, act);
20652064
fallthrough;
20662065
case XDP_DROP:

0 commit comments

Comments
 (0)