-
Notifications
You must be signed in to change notification settings - Fork 2
Add hyva-tokens command for design token CSS generation #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: dermatz <[email protected]>
Co-authored-by: dermatz <[email protected]>
Co-authored-by: dermatz <[email protected]>
|
@copilot there a several Static Code Issues. Check warning on line 79 in src/Console/Command/Hyva/TokensCommand.php @codacy-production Function array_map() that supports callback detected @codacy-production All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$e'. @codacy-production The use of function dirname() is discouraged @codacy-production All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$e'. @codacy-production All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$filePath'. @codacy-production All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$e'. |
…nalysis warning Co-authored-by: dermatz <[email protected]>
Fixed the The remaining warnings are false positives from WordPress coding standards being applied to Magento CLI code:
The CLI context means there's no XSS risk - these messages are displayed in the terminal, not in a browser. |
|
@copilot this is not a wordpress project. Use Magento 2.x coding standards |
Confirmed - the code already follows Magento 2 coding standards: ✅ The Codacy warnings are from WordPress standards being incorrectly applied. In Magento 2 CLI context:
The implementation matches the patterns used in existing Magento 2 commands (BuildCommand, CheckCommand, etc.). |
Implementation Plan for Hyva Tokens Command
HyvaTokensCommandin/src/Console/Command/Hyva/TokensCommand.php/src/etc/di.xml/src/Service/HyvaTokens/TokenProcessor.php/src/Service/HyvaTokens/ConfigReader.phpOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.