-
Notifications
You must be signed in to change notification settings - Fork 221
Fix the error dialog not displaying in the old mobile web UI #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 0.10
Are you sure you want to change the base?
Conversation
|
Would you mind building olad/www/mobile.js please @nomis52 , as it looks like you did it last: When I tried, I got a massive changeset compared to the relative change I'd made, or even if not changing anything, and I'd rather avoid creating new bugs if we can help it. Hence I'm hoping your build of the unmodified code produces the same output it did when you last ran it, then it will only have my changes on top. |
|
If I rebuild with my old version of closure I get no diffs. This is what I use to build: trunk/closure/bin/build/closurebuilder.py --root=trunk/ --root=ola --namespace="ola.Setup" --output_mode=compiled --compiler_jar=compiler.jar --compiler_flags="--compilation_level=ADVANCED_OPTIMIZATIONS" > ../olad/www/ola.js trunk/closure/bin/build/closurebuilder.py --root=trunk/ --root=ola --namespace="ola.mobile" --output_mode=compiled --compiler_jar=compiler.jar --compiler_flags="--compilation_level=ADVANCED_OPTIMIZATIONS" > ../olad/www/mobile.js |
|
Sorry, this is too high risk to put into 0.10.1, please target master. |
No description provided.