Skip to content

Conversation

@peternewman
Copy link
Member

No description provided.

@peternewman peternewman added this to the 0.10.1 milestone Feb 29, 2016
@peternewman
Copy link
Member Author

Would you mind building olad/www/mobile.js please @nomis52 , as it looks like you did it last:
https://github.com/OpenLightingProject/ola/commits/master/olad/www/mobile.js

When I tried, I got a massive changeset compared to the relative change I'd made, or even if not changing anything, and I'd rather avoid creating new bugs if we can help it. Hence I'm hoping your build of the unmodified code produces the same output it did when you last ran it, then it will only have my changes on top.

@peternewman peternewman changed the title Fix the error dialog not displaying in the old web UI Fix the error dialog not displaying in the old mobile web UI Feb 29, 2016
@nomis52
Copy link
Member

nomis52 commented Feb 29, 2016

If I rebuild with my old version of closure I get no diffs.

This is what I use to build:

trunk/closure/bin/build/closurebuilder.py --root=trunk/ --root=ola --namespace="ola.Setup" --output_mode=compiled --compiler_jar=compiler.jar --compiler_flags="--compilation_level=ADVANCED_OPTIMIZATIONS" > ../olad/www/ola.js

trunk/closure/bin/build/closurebuilder.py --root=trunk/ --root=ola --namespace="ola.mobile" --output_mode=compiled --compiler_jar=compiler.jar --compiler_flags="--compilation_level=ADVANCED_OPTIMIZATIONS" > ../olad/www/mobile.js

@nomis52
Copy link
Member

nomis52 commented Feb 29, 2016

Sorry, this is too high risk to put into 0.10.1, please target master.

@peternewman peternewman modified the milestones: 0.10.1, 0.10.2 Feb 29, 2016
@peternewman peternewman modified the milestones: 0.11.0, 0.10.2 May 10, 2016
@peternewman peternewman modified the milestones: 0.10.4, 0.11.0 Feb 23, 2017
@peternewman peternewman modified the milestones: 0.11.0, 0.10.4 Apr 30, 2017
@peternewman peternewman assigned peternewman and unassigned nomis52 Apr 30, 2017
@peternewman peternewman modified the milestones: 0.11.0, 0.10.future Feb 19, 2018
@peternewman peternewman modified the milestones: 0.10.future, 0.future Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants