Add OVDMX device support #1580
Add OVDMX device support #1580
Conversation
…ust the stability of this just yet
…iage return in the byte stream. Was very annoying to debug...
|
This commit probably wants adding too: JanOveSaltvedt@5b95972 @aasmundeldhuset are you interested in helping to get this merged too? |
|
Or @stemnic |
|
I think it would be nice to have ovdmx integrated with the main branch of OLA. |
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
You also need to add the licence to the top of some files:
https://travis-ci.org/OpenLightingProject/ola/jobs/581847612#L1041-L1045
Fix some lint issues (although that's normally best done last):
https://travis-ci.org/OpenLightingProject/ola/jobs/581847611#L1635-L1642
|
|
||
| std::string Name() const { return PLUGIN_NAME; } | ||
| std::string Description() const; | ||
| ola_plugin_id Id() const { return OLA_PLUGIN_EXPERIMENTAL; } |
There was a problem hiding this comment.
See the notes here for how plugin IDs get assigned now: https://github.com/OpenLightingProject/ola/blob/master/common/protocol/Ola.proto#L72-L78
|
The initial compile failure on Linux is fairly simple @stemnic , just see the notes here: |
|
Great I will take a look at it and see if I can make it work |
Brilliant thanks. I think it's probably better if you re-open the PR because then I can approve it for merge (and you are a LOT more involved in the codebase than me, so I'll close this one so it lets you open a fresh one; at least I think it will then). |
3 participants
Hi @JanOveSaltvedt ,
I see you've added support for your ovdmx dongle to OLA and for the dongle here:
https://github.com/JanOveSaltvedt/ovdmx
We can get this merged into OLA mainline if you'd like as you seem to have a little bit of a tree of users of your codebase:
https://github.com/JanOveSaltvedt/ola-ovdmx/network/members
From a quick look the initial code doesn't look too far off being ready to merge.