Add InternalImportsByDefault support (#151)

Kyle-Ye · web-flow · commit d670436643f1 · 2024-11-03T13:55:01.000+08:00
diff --git a/Package.swift b/Package.swift
@@ -55,7 +55,7 @@ default:
 
 var sharedSwiftSettings: [SwiftSetting] = [
     .enableUpcomingFeature("BareSlashRegexLiterals"),
-    // .enableUpcomingFeature("InternalImportsByDefault"),
+    .enableUpcomingFeature("InternalImportsByDefault"),
     .define("OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS"),
     .define("OPENSWIFTUI_RELEASE_\(releaseVersion)"),
     .swiftLanguageMode(.v5),
diff --git a/Sources/OpenSwiftUI/EventHandling/SystemEvent/OpenURLAction.swift b/Sources/OpenSwiftUI/EventHandling/SystemEvent/OpenURLAction.swift
@@ -6,7 +6,7 @@
 //  Status: Complete
 //  ID: 1F1831D737D24A15A8A759DDE72CEF68
 
-import Foundation
+public import Foundation
 
 /// An action that opens a URL.
 ///
diff --git a/Sources/OpenSwiftUI/Integration/Representable/UIKit/UIViewRepresentable.swift b/Sources/OpenSwiftUI/Integration/Representable/UIKit/UIViewRepresentable.swift
@@ -7,7 +7,7 @@
 
 #if os(iOS)
 
-import UIKit
+public import UIKit
 
 /// A wrapper for a UIKit view that you use to integrate that view into your
 /// OpenSwiftUI view hierarchy.
diff --git a/Sources/OpenSwiftUI/Integration/UIKit/UIHostingController.swift b/Sources/OpenSwiftUI/Integration/UIKit/UIHostingController.swift
@@ -1,5 +1,5 @@
 #if os(iOS)
-import UIKit
+public import UIKit
 
 @available(macOS, unavailable)
 @available(watchOS, unavailable)
diff --git a/Sources/OpenSwiftUI/Integration/UIKit/UIHostingView.swift b/Sources/OpenSwiftUI/Integration/UIKit/UIHostingView.swift
@@ -8,7 +8,7 @@
 
 #if os(iOS)
 @_spi(ForOpenSwiftUIOnly) public import OpenSwiftUICore
-import UIKit
+public import UIKit
 
 @available(macOS, unavailable)
 @available(watchOS, unavailable)
diff --git a/Sources/OpenSwiftUI/Test/_BenchmarkHost.swift b/Sources/OpenSwiftUI/Test/_BenchmarkHost.swift
@@ -6,7 +6,7 @@
 //  Status: Complete
 //  ID: 3E629D505F0A70F29ACFC010AA42C6E0
 
-import Foundation
+public import Foundation
 
 #if canImport(QuartzCore)
 import QuartzCore
diff --git a/Sources/OpenSwiftUI/View/Control/Link/Link.swift b/Sources/OpenSwiftUI/View/Control/Link/Link.swift
@@ -5,7 +5,7 @@
 //  Audited for RELEASE_2021
 //  Status: Blocked by Text and Accessibility
 
-import Foundation
+public import Foundation
 
 /// A control for navigating to a URL.
 ///
diff --git a/Sources/OpenSwiftUICore/Animation/TODO/Animatable.swift b/Sources/OpenSwiftUICore/Animation/TODO/Animatable.swift
@@ -5,6 +5,8 @@
 //  Audited for RELEASE_2021
 //  Status: Blocked by Graph
 
+public import Foundation
+
 // MARK: - Animatable
 
 /// A type that describes how to animate a property of a view.
@@ -48,8 +50,6 @@ extension Animatable where AnimatableData == EmptyAnimatableData {
     }
 }
 
-import Foundation
-
 // MARK: - Animatable + CoreGraphics
 
 extension CGPoint: Animatable {
diff --git a/Sources/OpenSwiftUICore/Animation/VectorArithmetic.swift b/Sources/OpenSwiftUICore/Animation/VectorArithmetic.swift
@@ -5,6 +5,8 @@
 //  Audited for RELEASE_2023
 //  Status: Complete
 
+public import Foundation
+
 public protocol VectorArithmetic: AdditiveArithmetic {
     mutating func scale(by rhs: Double)
     var magnitudeSquared: Double { get }
@@ -56,8 +58,6 @@ extension Double: VectorArithmetic {
     }
 }
 
-import Foundation
-
 extension CGFloat: VectorArithmetic {
     @_transparent
     public mutating func scale(by rhs: Double) { self *= CGFloat(rhs) }
diff --git a/Sources/OpenSwiftUICore/Data/Environment/Environment.swift b/Sources/OpenSwiftUICore/Data/Environment/Environment.swift
@@ -8,9 +8,9 @@
 
 internal import OpenGraphShims
 #if OPENSWIFTUI_SWIFT_LOG
-import Logging
+public import Logging
 #else
-import os
+public import os
 #endif
 
 /// A property wrapper that reads a value from a view's environment.
diff --git a/Sources/OpenSwiftUICore/Data/Protobuf/ProtobufDecoder.swift b/Sources/OpenSwiftUICore/Data/Protobuf/ProtobufDecoder.swift
@@ -6,7 +6,7 @@
 //  Status: Complete
 //  ID: FFA06CAF6B06DC3E21EC75547A0CD421
 
-import Foundation
+package import Foundation
 
 /// An object that decodes instances of a data type from protobuf objects.
 package struct ProtobufDecoder {
diff --git a/Sources/OpenSwiftUICore/Data/Protobuf/ProtobufEncoder.swift b/Sources/OpenSwiftUICore/Data/Protobuf/ProtobufEncoder.swift
@@ -6,7 +6,7 @@
 //  Status: Complete
 //  ID: C7B3AAD101AF9EA76FC322BD6EF713E6
 
-import Foundation
+package import Foundation
 
 /// An object that encodes instances of a data type as protobuf objects.
 package struct ProtobufEncoder {
diff --git a/Sources/OpenSwiftUICore/Data/State/ObservedObject.swift b/Sources/OpenSwiftUICore/Data/State/ObservedObject.swift
@@ -6,9 +6,9 @@
 //  Status: Blocked by DynamicProperty
 
 #if OPENSWIFTUI_OPENCOMBINE
-import OpenCombine
+public import OpenCombine
 #else
-import Combine
+public import Combine
 #endif
 
 /// A property wrapper type that subscribes to an observable object and
diff --git a/Sources/OpenSwiftUICore/Data/State/StateObject.swift b/Sources/OpenSwiftUICore/Data/State/StateObject.swift
@@ -6,9 +6,9 @@
 //  Status: Blocked by DynamicProperty
 
 #if OPENSWIFTUI_OPENCOMBINE
-import OpenCombine
+public import OpenCombine
 #else
-import Combine
+public import Combine
 #endif
 
 /// A property wrapper type that instantiates an observable object.
diff --git a/Sources/OpenSwiftUICore/Graphic/Color/Color.swift b/Sources/OpenSwiftUICore/Graphic/Color/Color.swift
@@ -8,7 +8,7 @@
 
 import Foundation
 #if canImport(Darwin)
-import CoreGraphics
+public import CoreGraphics
 #endif
 
 /// A representation of a color that adapts to a given context.
diff --git a/Sources/OpenSwiftUICore/Graphic/Color/ColorResolved.swift b/Sources/OpenSwiftUICore/Graphic/Color/ColorResolved.swift
@@ -5,7 +5,11 @@
 //  Audited for RELEASE_2024
 //  Status: WIP
 
+#if canImport(Darwin)
+package import Foundation
+#else
 import Foundation
+#endif
 internal import OpenSwiftUI_SPI
 
 // MARK: - Color.Resolved
diff --git a/Sources/OpenSwiftUICore/Graphic/Color/CoreColor+Extension.swift b/Sources/OpenSwiftUICore/Graphic/Color/CoreColor+Extension.swift
@@ -6,7 +6,7 @@
 //  Status: Complete
 
 #if canImport(Darwin)
-import Foundation
+package import Foundation
 internal import OpenSwiftUI_SPI
 
 extension CoreColor {
diff --git a/Sources/OpenSwiftUICore/Layout/LayoutAdjustments/Alignment/AlignmentID.swift b/Sources/OpenSwiftUICore/Layout/LayoutAdjustments/Alignment/AlignmentID.swift
@@ -5,7 +5,7 @@
 //  Audited for RELEASE_2021
 //  Status: Complete
 
-import Foundation
+public import Foundation
 
 /// A type that you use to create custom alignment guides.
 ///
diff --git a/Sources/OpenSwiftUICore/Layout/LayoutAdjustments/Alignment/ViewDimensions.swift b/Sources/OpenSwiftUICore/Layout/LayoutAdjustments/Alignment/ViewDimensions.swift
@@ -5,7 +5,7 @@
 //  Audited for RELEASE_2021
 //  Status: Complete
 
-import Foundation
+public import Foundation
 
 /// A view's size and alignment guides in its own coordinate space.
 ///
diff --git a/Sources/OpenSwiftUICore/Layout/LayoutAdjustments/Direction/LayoutDirection.swift b/Sources/OpenSwiftUICore/Layout/LayoutAdjustments/Direction/LayoutDirection.swift
@@ -40,7 +40,7 @@ extension LayoutDirection: Sendable {}
 #if canImport(UIKit)
 // MARK: - UIKit integration
 
-import UIKit
+public import UIKit
 
 extension LayoutDirection {
     /// Create a direction from its UITraitEnvironmentLayoutDirection equivalent.
diff --git a/Sources/OpenSwiftUICore/Layout/LayoutAdjustments/Edge/EdgeInsets.swift b/Sources/OpenSwiftUICore/Layout/LayoutAdjustments/Edge/EdgeInsets.swift
@@ -5,7 +5,7 @@
 //  Audited for RELEASE_2021
 //  Status: Complete
 
-import Foundation
+public import Foundation
 
 /// The inset distances for the sides of a rectangle.
 @frozen
@@ -91,9 +91,9 @@ extension EdgeInsets: Sendable {}
 // MARK: - UIKit/AppKit integration
 
 #if canImport(UIKit)
-import UIKit
+public import UIKit
 #elseif canImport(AppKit)
-import AppKit
+public import AppKit
 #endif
 extension EdgeInsets {
     /// Create edge insets from the equivalent NSDirectionalEdgeInsets.
diff --git a/Sources/OpenSwiftUICore/Layout/LayoutAdjustments/Padding/PaddingLayout.swift b/Sources/OpenSwiftUICore/Layout/LayoutAdjustments/Padding/PaddingLayout.swift
@@ -5,7 +5,7 @@
 //  Audited for RELEASE_2021
 //  Status: WIP
 
-import Foundation
+public import Foundation
 
 @frozen
 public struct _PaddingLayout: /* UnaryLayout, */ Animatable, PrimitiveViewModifier /* , MultiViewModifier */ {
diff --git a/Sources/OpenSwiftUICore/Layout/LayoutFundamentals/Separators/Spacer.swift b/Sources/OpenSwiftUICore/Layout/LayoutFundamentals/Separators/Spacer.swift
@@ -5,7 +5,7 @@
 //  Audited for RELEASE_2021
 //  Status: TODO
 
-import Foundation
+public import Foundation
 
 /// A flexible space that expands along the major axis of its containing stack
 /// layout, or on both axes if not contained in a stack.
diff --git a/Sources/OpenSwiftUICore/Layout/LayoutFundamentals/Stack/HVStack.swift b/Sources/OpenSwiftUICore/Layout/LayoutFundamentals/Stack/HVStack.swift
@@ -1,4 +1,4 @@
-import Foundation
+public import Foundation
 
 @frozen
 public struct HStack<Content: View>: PrimitiveView {
diff --git a/Sources/OpenSwiftUICore/Layout/LayoutFundamentals/Stack/HVStackLayout.swift b/Sources/OpenSwiftUICore/Layout/LayoutFundamentals/Stack/HVStackLayout.swift
@@ -1,4 +1,4 @@
-import Foundation
+public import Foundation
 
 /// A layout that arranges its children in a horizontal line.
 @frozen
diff --git a/Sources/OpenSwiftUICore/Layout/LayoutFundamentals/internal/ProjectionTransform.swift b/Sources/OpenSwiftUICore/Layout/LayoutFundamentals/internal/ProjectionTransform.swift
@@ -5,9 +5,9 @@
 //  Audited for RELEASE_2021
 //  Status: WIP
 
-import Foundation
+public import Foundation
 #if canImport(QuartzCore)
-import QuartzCore
+public import QuartzCore
 #endif
 
 @frozen
diff --git a/Sources/OpenSwiftUICore/Log/Logging.swift b/Sources/OpenSwiftUICore/Log/Logging.swift
@@ -7,7 +7,7 @@
 
 import Foundation
 #if OPENSWIFTUI_SWIFT_LOG
-import Logging
+public import Logging
 extension Logger {
     package init(subsystem: String, category: String) {
         var logger = Logger(label: subsystem)
@@ -16,7 +16,7 @@ extension Logger {
     }
 }
 #else
-import os.log
+public import os.log
 
 #if DEBUG
 package let dso = { () -> UnsafeMutableRawPointer in
diff --git a/Sources/OpenSwiftUICore/Log/Signpost.swift b/Sources/OpenSwiftUICore/Log/Signpost.swift
@@ -10,7 +10,7 @@
 internal import OpenSwiftUI_SPI
 internal import OpenGraphShims
 #if canImport(Darwin)
-import os.signpost
+package import os.signpost
 #endif
 
 extension Signpost {
diff --git a/Sources/OpenSwiftUICore/Modifier/ClipEffect.swift b/Sources/OpenSwiftUICore/Modifier/ClipEffect.swift
@@ -1,4 +1,4 @@
-import Foundation
+public import Foundation
 
 // MARK: - ClipEffect
 
diff --git a/Sources/OpenSwiftUICore/Render/DisplayList/DisplayList.GraphicsRenderer.swift b/Sources/OpenSwiftUICore/Render/DisplayList/DisplayList.GraphicsRenderer.swift
@@ -6,7 +6,7 @@
 //  Status: Blocked by RenderBox and GraphicsContext
 //  ID: EFAEDE41CB8C85EF3A6A18DC05438A3C
 
-import Foundation
+package import Foundation
 
 extension DisplayList {
     final package class GraphicsRenderer {
diff --git a/Sources/OpenSwiftUICore/Render/DisplayList/DisplayList.ViewRenderer.swift b/Sources/OpenSwiftUICore/Render/DisplayList/DisplayList.ViewRenderer.swift
@@ -6,7 +6,7 @@
 //  Status: Blocked by ViewUpdater and ViewRasterizer
 //  ID: 21FFA3C7D88AC65BB559906758271BFC
 
-import Foundation
+package import Foundation
 
 protocol ViewRendererBase {
     var platform: DisplayList.ViewUpdater.Platform { get }
diff --git a/Sources/OpenSwiftUICore/Render/DisplayList/DisplayList.swift b/Sources/OpenSwiftUICore/Render/DisplayList/DisplayList.swift
@@ -6,7 +6,7 @@
 //  Status: WIP
 //  ID: F37E3733E490AA5E3BDC045E3D34D9F8
 
-import Foundation
+package import Foundation
 
 // MARK: - _DisplayList_Identity
 
diff --git a/Sources/OpenSwiftUICore/Render/PlatformViewDefinition.swift b/Sources/OpenSwiftUICore/Render/PlatformViewDefinition.swift
@@ -7,7 +7,7 @@
 
 internal import OpenSwiftUI_SPI
 #if canImport(Darwin)
-import QuartzCore
+public import QuartzCore
 #endif
 
 @_spi(DisplayList_ViewSystem)
diff --git a/Sources/OpenSwiftUICore/Semantic/Feature.swift b/Sources/OpenSwiftUICore/Semantic/Feature.swift
@@ -5,7 +5,7 @@
 //  Audited for RELEASE_2024
 //  Status: Complete
 
-import Foundation
+package import Foundation
 
 package protocol Feature: ViewInputBoolFlag {
     static var isEnabled: Bool { get }
diff --git a/Sources/OpenSwiftUICore/Shape/Path/Path.swift b/Sources/OpenSwiftUICore/Shape/Path/Path.swift
@@ -7,11 +7,11 @@
 //  ID: 31FD92B70C320DDD253E93C7417D779A RELEASE_2021
 //  ID: 3591905F51357E95FA93E39751507471 RELEASE_2024
 
-import Foundation
+public import Foundation
 
 #if canImport(CoreGraphics)
 internal import OpenSwiftUI_SPI
-import CoreGraphics
+public import CoreGraphics
 
 @_silgen_name("__CGPathParseString")
 private func __CGPathParseString(_ path: CGMutablePath, _ utf8CString: UnsafePointer<CChar>) -> Bool
diff --git a/Sources/OpenSwiftUICore/Shape/Rectangle.swift b/Sources/OpenSwiftUICore/Shape/Rectangle.swift
@@ -1,4 +1,4 @@
-import Foundation
+public import Foundation
 
 /// A rectangular shape aligned inside the frame of the view containing it.
 @frozen
diff --git a/Sources/OpenSwiftUICore/Shape/RoundedRectangle.swift b/Sources/OpenSwiftUICore/Shape/RoundedRectangle.swift
@@ -1,4 +1,4 @@
-import Foundation
+public import Foundation
 
 @frozen
 public struct RoundedRectangle: Shape {
diff --git a/Sources/OpenSwiftUICore/Shape/Shape.swift b/Sources/OpenSwiftUICore/Shape/Shape.swift
@@ -5,7 +5,7 @@
 //  Audited for RELEASE_2021
 //  Status: WIP
 
-import Foundation
+public import Foundation
 
 /// A 2D shape that you can use when drawing a view.
 ///
diff --git a/Sources/OpenSwiftUICore/Shape/StrokeStyle.swift b/Sources/OpenSwiftUICore/Shape/StrokeStyle.swift
@@ -5,9 +5,9 @@
 //  Audited for RELEASE_2021
 //  Status: Complete
 
-import Foundation
+public import Foundation
 #if canImport(CoreGraphics)
-import CoreGraphics
+public import CoreGraphics
 #else
 /// Line join styles
 public enum CGLineJoin: Int32, @unchecked Sendable {
diff --git a/Sources/OpenSwiftUICore/Text/Font/TODO/Font.swift b/Sources/OpenSwiftUICore/Text/Font/TODO/Font.swift
diff --git a/Sources/OpenSwiftUICore/Text/Text/TODO/Text.swift b/Sources/OpenSwiftUICore/Text/Text/TODO/Text.swift
diff --git a/Sources/OpenSwiftUICore/View/Debug/ViewDebug.swift b/Sources/OpenSwiftUICore/View/Debug/ViewDebug.swift
diff --git a/Sources/OpenSwiftUICore/View/Graph/ViewRendererHost.swift b/Sources/OpenSwiftUICore/View/Graph/ViewRendererHost.swift
diff --git a/Sources/OpenSwiftUIExtension/TappablePadding.swift b/Sources/OpenSwiftUIExtension/TappablePadding.swift

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,8 @@`
`5`	`5`	`// Audited for RELEASE_2021`
`6`	`6`	`// Status: Blocked by Graph`
`7`	`7`
	`8`	`+public import Foundation`
	`9`	`+`
`8`	`10`	`// MARK: - Animatable`
`9`	`11`
`10`	`12`	`/// A type that describes how to animate a property of a view.`
`@@ -48,8 +50,6 @@ extension Animatable where AnimatableData == EmptyAnimatableData {`
`48`	`50`	`}`
`49`	`51`	`}`
`50`	`52`
`51`		`-import Foundation`
`52`		`-`
`53`	`53`	`// MARK: - Animatable + CoreGraphics`
`54`	`54`
`55`	`55`	`extension CGPoint: Animatable {`