From 7096dad64503604b3a82fd7d9c21dfe451ff0ac8 Mon Sep 17 00:00:00 2001 From: Pyit Phyo Aung Date: Sun, 1 Oct 2017 22:46:14 +1300 Subject: [PATCH] (issue #516) clean up commented codes and todo usages --- config/webpack.config.dev.js | 4 ---- config/webpack.config.prod.js | 4 ---- src/scenes/home/families/jumboQuote/jumboQuote.js | 2 -- src/scenes/home/history/history.js | 1 - src/scenes/home/history/timelineEvent/timelineEvent.js | 2 -- src/scenes/home/landing/whatWeDo/whatWeDo.js | 8 -------- src/shared/components/join/join.js | 1 - src/shared/utils/cookieHelper.js | 2 -- 8 files changed, 24 deletions(-) diff --git a/config/webpack.config.dev.js b/config/webpack.config.dev.js index 945ffba3b..2e1183757 100644 --- a/config/webpack.config.dev.js +++ b/config/webpack.config.dev.js @@ -117,10 +117,6 @@ module.exports = { module: { strictExportPresence: true, rules: [ - // TODO: Disable require.ensure as it's not a standard language feature. - // We are waiting for https://github.com/facebookincubator/create-react-app/issues/2176. - // { parser: { requireEnsure: false } }, - // First, run the linter. // It's important to do this before Babel processes the JS. { diff --git a/config/webpack.config.prod.js b/config/webpack.config.prod.js index 60af97be6..1c762d3de 100644 --- a/config/webpack.config.prod.js +++ b/config/webpack.config.prod.js @@ -116,10 +116,6 @@ module.exports = { module: { strictExportPresence: true, rules: [ - // TODO: Disable require.ensure as it's not a standard language feature. - // We are waiting for https://github.com/facebookincubator/create-react-app/issues/2176. - // { parser: { requireEnsure: false } }, - // First, run the linter. // It's important to do this before Babel processes the JS. { diff --git a/src/scenes/home/families/jumboQuote/jumboQuote.js b/src/scenes/home/families/jumboQuote/jumboQuote.js index 36c04110d..2ee350c69 100644 --- a/src/scenes/home/families/jumboQuote/jumboQuote.js +++ b/src/scenes/home/families/jumboQuote/jumboQuote.js @@ -13,8 +13,6 @@ class JumboQuote extends Component { }; } - // TODO: Ditch bluebird promise for axios to drop a dependency - // TODO: Is there a need to move the quotes to a back-end API endpoint, or should we just bail on the promise-based API request idea for this data? componentDidMount() { Promise.try( () => quotes.quotes[Math.floor(Math.random() * quotes.quotes.length)] diff --git a/src/scenes/home/history/history.js b/src/scenes/home/history/history.js index 55d61150f..ade4b632d 100644 --- a/src/scenes/home/history/history.js +++ b/src/scenes/home/history/history.js @@ -2,7 +2,6 @@ import React, { Component } from 'react'; import Section from 'shared/components/section/section'; import QuoteBanner from 'shared/components/quoteBanner/quoteBanner'; import Timeline from './timeline/timeline'; -// import styles from './history.css'; class History extends Component { render() { diff --git a/src/scenes/home/history/timelineEvent/timelineEvent.js b/src/scenes/home/history/timelineEvent/timelineEvent.js index 19d5ce7bd..2bb33a734 100644 --- a/src/scenes/home/history/timelineEvent/timelineEvent.js +++ b/src/scenes/home/history/timelineEvent/timelineEvent.js @@ -3,8 +3,6 @@ import PropTypes from 'prop-types'; import styles from './timelineEvent.css'; class TimelineEvent extends Component { - // TODO: Force eventTitle to Title case with Regex - render() { return (
diff --git a/src/scenes/home/landing/whatWeDo/whatWeDo.js b/src/scenes/home/landing/whatWeDo/whatWeDo.js index 308186583..f678a454e 100644 --- a/src/scenes/home/landing/whatWeDo/whatWeDo.js +++ b/src/scenes/home/landing/whatWeDo/whatWeDo.js @@ -17,29 +17,21 @@ class WhatWeDo extends Component { image={image1} title={content.items[0].title} cardText={content.items[0].body} - // buttonText={content.items[0].buttonText} - // link={content.items[0].linkTo} />
diff --git a/src/shared/components/join/join.js b/src/shared/components/join/join.js index ae17b3a7f..4a3ba985e 100644 --- a/src/shared/components/join/join.js +++ b/src/shared/components/join/join.js @@ -1,5 +1,4 @@ import React from 'react'; -// import PropTypes from 'prop-types'; import Section from 'shared/components/section/section'; import LinkButton from 'shared/components/linkButton/linkButton'; import styles from './join.css'; diff --git a/src/shared/utils/cookieHelper.js b/src/shared/utils/cookieHelper.js index f9bb126a0..07d5cf7a0 100644 --- a/src/shared/utils/cookieHelper.js +++ b/src/shared/utils/cookieHelper.js @@ -47,8 +47,6 @@ const validToken = (token) => { const jwt = jwt_decode(token); const currentTime = new Date().getTime() / 1000; - // TODO we could validate the signature as well (issue#281) - if (currentTime > jwt.exp) { return false; } return true;