-
-
Notifications
You must be signed in to change notification settings - Fork 65
Dockerfile should not be root #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think I could work on this - Also I had a minor side question about the .PHONY: bg
bg:
${DOCKER_COMPOSE} up --build -d # A new db and resource container created and running
#--------------------Some other stuff------------------------------
.PHONY: setup
setup: bg
${DOCKER_COMPOSE} run ${RESOURCES_CONTAINER} ${FLASK} # Another new oneshot container created
${DOCKER_COMPOSE} run ${RESOURCES_CONTAINER} ${FLASK} db-migrate create-tables # Again
${DOCKER_COMPOSE} run ${RESOURCES_CONTAINER} ${FLASK} db stamp head # Again
${DOCKER_COMPOSE} run ${RESOURCES_CONTAINER} ${FLASK} db-migrate init # Again This leads to multiple uneccessary stopped containers, if we substitute the Edit: welp nvm, platipo seems to be working on it |
At the time, I don't think any of us realized that it wasn't using the same container. Feel free to change it to |
Right now, the Dockerfile runs as root because that's the default. Instead, there should be a non-root user that the uwsgi process runs as.
The text was updated successfully, but these errors were encountered: