Cloning doesn't overwrite identity (#8487)

Matteo Piovanelli · web-flow · commit af42947c9cfc · 2021-07-30T08:40:53.000+02:00
Fixes #8486
diff --git a/src/Orchard.Web/Core/Common/Handlers/IdentityPartHandler.cs b/src/Orchard.Web/Core/Common/Handlers/IdentityPartHandler.cs
@@ -10,7 +10,7 @@ public IdentityPartHandler(IRepository<IdentityPartRecord> identityRepository,
             IContentManager contentManager) {
             Filters.Add(StorageFilter.For(identityRepository));
             OnInitializing<IdentityPart>((ctx, part) => AssignIdentity(part));
-            OnCloning<IdentityPart>((ctx, part) => AssignIdentity(part));
+            OnCloning<IdentityPart>((ctx, part) => AssignIdentity(ctx.CloneContentItem.As<IdentityPart>()));
 
             OnIndexing<IdentityPart>((context, part) => {
                 context.DocumentIndex.Add("identifier", part.Identifier).Store();
@@ -32,4 +32,4 @@ protected override void GetItemMetadata(GetContentItemMetadataContext context) {
             }
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ public IdentityPartHandler(IRepository<IdentityPartRecord> identityRepository,`
`10`	`10`	`IContentManager contentManager) {`
`11`	`11`	`Filters.Add(StorageFilter.For(identityRepository));`
`12`	`12`	`OnInitializing<IdentityPart>((ctx, part) => AssignIdentity(part));`
`13`		`- OnCloning<IdentityPart>((ctx, part) => AssignIdentity(part));`
	`13`	`+ OnCloning<IdentityPart>((ctx, part) => AssignIdentity(ctx.CloneContentItem.As<IdentityPart>()));`
`14`	`14`
`15`	`15`	`OnIndexing<IdentityPart>((context, part) => {`
`16`	`16`	`context.DocumentIndex.Add("identifier", part.Identifier).Store();`
`@@ -32,4 +32,4 @@ protected override void GetItemMetadata(GetContentItemMetadataContext context) {`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`	`}`
`35`		`-}`
	`35`	`+}`